add initial list of draft token tags#15
Open
georgedonnelly wants to merge 1 commit intoOpenTokenRegistry:masterfrom
Open
add initial list of draft token tags#15georgedonnelly wants to merge 1 commit intoOpenTokenRegistry:masterfrom
georgedonnelly wants to merge 1 commit intoOpenTokenRegistry:masterfrom
Conversation
Member
|
This is looking great @georgedonnelly, thanks for the contribution! Is this list derived from anywhere in particular, or is it original? (I want to verify compatibility with OTR's CC0 licensing before merging.) This list seems to cover the known spectrum of tokens. The BCMR spec has some other examples, but I think this list includes all of the types of tags we'd currently expect to have in OTR. I have 2 nits:
|
Member
Author
|
Thanks for taking a look! I got the list from GPT4. I can rewrite myself from scratch if you like, no problem at all. I agree, privacy-token does not fit. re |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to offer this initial draft of a list of tags for tokens and see what the community thinks about token tags in BCMRs.