Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the example plotting scripts by de-duplicating shared plotting logic between the interactive GUI (examples/plots.jl) and the CLI batch plot tool (examples/batch_plot.jl) into shared includes.
Changes:
- Extract shared plotting implementations into
examples/plot_functions.jland shared accessors intoexamples/plot_helpers.jl. - Convert
examples/plots.jlandexamples/batch_plot.jlto lightweight wrappers that load logs and delegate to the shared plot functions. - Optimize log accessor extraction in
examples/plot_loading.jlby replacinghcat(...)[1,:]with broadcastedgetindex.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/plots.jl | Replaced duplicated plot implementations with wrappers delegating to shared plot functions; keeps GUI-specific log loading and timing plots. |
| examples/plot_loading.jl | Uses getindex.(..., 1) to extract scalar series without allocating via hcat. |
| examples/plot_helpers.jl | New shared accessors (l_tether, force, v_reelout) for syslog series extraction. |
| examples/plot_functions.jl | New shared plotting implementations (_plot_*) used by both GUI and CLI wrappers. |
| examples/batch_plot.jl | Replaced duplicated plotting logic with wrappers delegating to plot_functions.jl. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plot functions were defined twice, once in
plots.jland once inbatch_plots.jl.