Skip to content

Add Rainbii.oscmeta#110

Merged
GabubuAvailable merged 11 commits intoOpenShopChannel:masterfrom
Def64:master
Jun 14, 2025
Merged

Add Rainbii.oscmeta#110
GabubuAvailable merged 11 commits intoOpenShopChannel:masterfrom
Def64:master

Conversation

@Def64
Copy link
Contributor

@Def64 Def64 commented Jun 7, 2025

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you verified that the manifest contains valid JSON?
  • Are you certain that this manifest is not designed to obtain copyrighted material or software, which you do not have permission to distribute?
  • Submitting malicious software is strictly forbidden, and potentially constitutes criminal activity, punishable by law. To the best of your knowledge, is this submission clear of any malicious intent?

Note: filename.oscmeta is the slug of the application you are submitting. This slug is used to locate files such as "/apps/slug/boot.dol" and "/apps/slug/meta.xml" in the final archive generated by this manifest. These files should be available at this location.


@Def64 Def64 marked this pull request as draft June 7, 2025 22:03
@Def64 Def64 marked this pull request as ready for review June 7, 2025 22:21
@Def64
Copy link
Contributor Author

Def64 commented Jun 11, 2025

um

@abdelali221
Copy link
Contributor

your repository is empty

@Def64
Copy link
Contributor Author

Def64 commented Jun 12, 2025

so now what

@GabubuAvailable GabubuAvailable added needs review - do not merge Special attention and consideration is required to merge. awaiting response labels Jun 12, 2025
Copy link
Member

@GabubuAvailable GabubuAvailable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The download link is a Google Drive. OSC does not support that so we recommend uploading to GitHub as release then modifying the meta.
  2. Speaking of GitHub, I've found your repo but there is no source code at all. Showing a source code will be useful in most of cases, in order to not host malware.
  3. The app meta results an error... "error on line 11 at column 20: Opening and ending tag mismatch: app line 2 and long_description"

I would like to consider solving everything mentioned above, then we'll check before merging this PR. Thank you!

@Def64
Copy link
Contributor Author

Def64 commented Jun 14, 2025

check now; i've uploaded it to github, and fixed the app meta

Copy link
Member

@GabubuAvailable GabubuAvailable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Would be preferably if you can set a release date on your app's meta.xml file. I will also change the category to "Demos" later, since that doesn't look as a "Media" app. Thank you!

@GabubuAvailable GabubuAvailable merged commit ed4d7d8 into OpenShopChannel:master Jun 14, 2025
1 check passed
@GabubuAvailable GabubuAvailable added new app New App added to repository and removed needs review - do not merge Special attention and consideration is required to merge. awaiting response labels Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new app New App added to repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants