Conversation
Keep model selection, fetched models, and proxy examples aligned on the supported ID while dropping stale legacy aliases. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> Correct the canonical Llama model ID Use llama3-3-70b as the supported identifier and keep dotted legacy values migrating to it. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
📝 WalkthroughWalkthroughA centralized model ID aliasing system is introduced via a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| const MODEL_NAME_ALIASES: Record<string, string> = { | ||
| "llama-3.3-70b": LLAMA_MODEL_ID, | ||
| "gemma-3-27b": "gemma4-31b", | ||
| "deepseek-r1-0528": "kimi-k2-5", | ||
| "kimi-k2": "kimi-k2-5", | ||
| "kimi-k2-thinking": "kimi-k2-5" | ||
| }; |
There was a problem hiding this comment.
🔴 Dropped backward-compatibility aliases for three old model names
The refactoring from if-else to a lookup table removed three previously-existing aliases:
"ibnzterrell/Meta-Llama-3.3-70B-Instruct-AWQ-INT4"(was →"llama-3.3-70b", which chains to"llama3-3-70b")"qwen3-coder-480b"(was →"kimi-k2-5")"leon-se/gemma-3-27b-it-fp8-dynamic"(was →"gemma4-31b")
These aliases exist for backward compatibility with persisted user data. When getChatById loads a chat at LocalStateContext.tsx:241, it calls aliasModelName(parsedChat.model). If a user has an old chat stored with one of these model names, it will now pass through un-aliased. The unrecognized model name then won't match any MODEL_CONFIG entry in ModelSelector.tsx, causing incorrect token limit fallbacks (via getModelTokenLimit at frontend/src/components/ModelSelector.tsx:78) and broken display names. Similarly, persistChat at frontend/src/state/LocalStateContext.tsx:96 will re-persist the unrecognized name rather than migrating it.
| const MODEL_NAME_ALIASES: Record<string, string> = { | |
| "llama-3.3-70b": LLAMA_MODEL_ID, | |
| "gemma-3-27b": "gemma4-31b", | |
| "deepseek-r1-0528": "kimi-k2-5", | |
| "kimi-k2": "kimi-k2-5", | |
| "kimi-k2-thinking": "kimi-k2-5" | |
| }; | |
| const MODEL_NAME_ALIASES: Record<string, string> = { | |
| "ibnzterrell/Meta-Llama-3.3-70B-Instruct-AWQ-INT4": LLAMA_MODEL_ID, | |
| "llama-3.3-70b": LLAMA_MODEL_ID, | |
| "leon-se/gemma-3-27b-it-fp8-dynamic": "gemma4-31b", | |
| "gemma-3-27b": "gemma4-31b", | |
| "qwen3-coder-480b": "kimi-k2-5", | |
| "deepseek-r1-0528": "kimi-k2-5", | |
| "kimi-k2": "kimi-k2-5", | |
| "kimi-k2-thinking": "kimi-k2-5" | |
| }; |
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Testing