Skip to content

Integrate Clang AddressSanitizer in tests - #1903

Merged
jordimas merged 11 commits into
OpenNMT:masterfrom
3manifold:asan
Jan 21, 2026
Merged

Integrate Clang AddressSanitizer in tests#1903
jordimas merged 11 commits into
OpenNMT:masterfrom
3manifold:asan

Conversation

@3manifold

@3manifold 3manifold commented Jul 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tested: temporarily introduced a memory leak in an operator to check that asan works:
https://github.com/OpenNMT/CTranslate2/actions/runs/16419223767/job/46392885237#logs

resolves #1928

@3manifold 3manifold changed the title Mem checks M checks Jul 17, 2025
@3manifold
3manifold force-pushed the asan branch 9 times, most recently from 5659d05 to 0efd96b Compare July 18, 2025 12:59
@3manifold 3manifold changed the title M checks [Test Feature] Integrate Google AddressSanitizer (aka ASan) in tests Jul 18, 2025
@3manifold 3manifold changed the title [Test Feature] Integrate Google AddressSanitizer (aka ASan) in tests Integrate Google AddressSanitizer (aka ASan) in tests Jul 18, 2025
3manifold
3manifold commented Jul 18, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
3manifold
3manifold commented Jul 18, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
@3manifold
3manifold marked this pull request as ready for review July 18, 2025 13:10
@jordimas

jordimas commented Jul 19, 2025

Copy link
Copy Markdown
Collaborator

For context:


sanitizers (Archived)

This project has been archived and is no longer actively maintained.

The Sanitizers project, which includes AddressSanitizer, MemorySanitizer, ThreadSanitizer, LeakSanitizer, 
and more, is now archived.

@3manifold

3manifold commented Jul 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

For context:


sanitizers (Archived)

This project has been archived and is no longer actively maintained.

The Sanitizers project, which includes AddressSanitizer, MemorySanitizer, ThreadSanitizer, LeakSanitizer, 
and more, is now archived.

Thanks for the note. Worth noting that sanitisers still exist but are maintained under the LLVM project (link). I can attempt later to re-run them under the LLVM ecosystem (using clang compiler etc. ). I updated the PR using clang this time.

@3manifold 3manifold changed the title Integrate Google AddressSanitizer (aka ASan) in tests Integrate Clang AddressSanitizer in tests Jul 21, 2025
@3manifold
3manifold force-pushed the asan branch 3 times, most recently from 83c0c09 to 9885b07 Compare July 21, 2025 14:10
@3manifold 3manifold mentioned this pull request Nov 6, 2025
Closed
jordimas
jordimas reviewed Dec 23, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml
jordimas
jordimas reviewed Dec 23, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
jordimas
jordimas reviewed Dec 23, 2025
View reviewed changes
Comment thread CMakeLists.txt
@jordimas jordimas mentioned this pull request Dec 23, 2025
Closed
@3manifold 3manifold mentioned this pull request Jan 6, 2026
Closed
@3manifold

3manifold commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@jordimas It seems that the address sanitiser detected an issue in one of the latest project changes ( see #1968 ). Apart from that, all comments were resolved.

@3manifold
3manifold force-pushed the asan branch 5 times, most recently from 7b8c6a4 to c909d4b Compare January 14, 2026 12:09
@3manifold

3manifold commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

@jordimas Rebased with latest master and all tests pass. The PR is ready to be merged.

@jordimas
jordimas merged commit 4d761f6 into OpenNMT:master Jan 21, 2026
17 checks passed
@3manifold 3manifold mentioned this pull request Jan 22, 2026
Open
Lanurence666 pushed a commit to Lanurence666/CTranslate2_backport_py38 that referenced this pull request May 23, 2026
@3manifold
Integrate Clang AddressSanitizer in tests (OpenNMT#1903)
c737243
veilnetwork pushed a commit to veilnetwork/CTranslate2 that referenced this pull request Aug 27, 2026
@3manifold
Integrate Clang AddressSanitizer in tests (OpenNMT#1903)
1924a4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordimas jordimas jordimas left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clang AddressSanitizer & ThreadSanitizer in CI

2 participants

@3manifold @jordimas