Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns OpenMage’s PHPStan configuration to use PHPStan’s PHP baseline format (instead of the previous NEON baseline references), ensuring CI and local tooling point to the correct baseline file format.
Changes:
- Update Composer script
phpstan:baselineto generate/update.phpstan.dist.baseline.php. - Update PHPStan config includes to load
.phpstan.dist.baseline.php. - Update CI workflow path filters and export-ignore rules to track the PHP baseline file.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
composer.json |
Switch phpstan:baseline script to target .phpstan.dist.baseline.php. |
.phpstan.dist.neon |
Update baseline include to .phpstan.dist.baseline.php. |
.github/workflows/workflow.yml |
Update workflow path filters to include .phpstan.dist.baseline.php. |
.gitattributes |
Export-ignore now applies to .phpstan.dist.baseline.php instead of the NEON baseline. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description (*)
https://phpstan.org/user-guide/baseline#php-baseline-format-instead-of-neon