Modernization #153
Draft
Modernization #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix datetime type error in users.py by passing datetime objects directly instead of converting to strings - Add type: ignore comments for anyio and CORSMiddleware where ty has inference issues - Add type narrowing assertions in conftest.py for None checks - All 463 unit tests pass - ty check passes with 0 errors
Adamkadaban
force-pushed
the
adam/modernization-staging
branch
from
7d7ebbb to
b7f6f36
Compare
- arq command now uses 'uv run arq' to ensure executable is in PATH - uvicorn command now uses 'uv run uvicorn' - All healthcheck commands now use 'uv run python' - This ensures uv-managed dependencies are properly accessible
- Update cryptography to >=46.0.0 (from >=41.0.0) - Update argon2-cffi to >=25.1.0 (from >=23.1.0) - Update cdktf to >=0.21.0 (from >=0.20) - Update cdktf-provider-aws to >=21.0.0 (from >=19.60) - Update setuptools-scm to ~=9.0 (from ~=8.1) - Update ruff to >=0.14.10 (from >=0.9.4) - Update testcontainers to >=4.13.3 (from >=4.9.1) All dependencies synced with uv.lock, security audit passed. Also fixed ty type checker warnings by: - Removing unused type: ignore comments that are no longer needed - Adding proper variable initialization and assertions to fix possibly-unresolved-reference warnings
Member
Author
|
It seems like ty does pretty well, but there are a good few false negatives, especially when working with pulumi, so I think it might be better to stick with mypy for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The goal of this PR is to make any fixes required to continue working on OpenLabs and to make quality of life improvements that will make our devloop faster.
This pull request modernizes the Python dependency and workflow management for the API by migrating from
pipandrequirements.txt/dev-requirements.txttouvwith apyproject.toml-based configuration. It also replaces MyPy with Ty for static type checking, updates all relevant documentation and CI workflows, and refactors Docker and test setups to useuv. Additionally, it improves email validation logic and makes minor code quality adjustments.So far, this PR:
api/src/app/core/setup.pyare being ignored right now. They can be removed pending these:__getattr__astral-sh/ruff#22314Partially Fixes: #152
I think pulumi should be a seperate PR