WIN32: add option to use system SDL3 libraries#130
Open
carlo-bramini wants to merge 1 commit into
Open
Conversation
Member
|
hey @carlo-bramini, is SDL3 complete/ready now? the only reason this was done, was I ran into trouble with some of the SDL3 stuff not being fully available/complete at the time it was implemented, otherwise it would of been VCPKG... as the compiling is a big pain. im happy to completely switch it over to vcpkg if thats the case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time of writing, compiling openfodder for
WIN32needs to download and build SDL3 libraries from sources.However, it would be useful to add an option for selecting if system libraries could be used on Windows.
So, I added
OPENFODDER_USE_SYSTEM_SDLfor this task.By default, this option is
OFFto reproduce the same behaviour of current sources.If
OPENFODDER_USE_SYSTEM_SDLisON, then SDL3 libraries are used if they are found.This simplifies the build process a lot, if you are using MinGW or MSVC together with vcpkg, without trouble in my opinion.