Skip to content

MHK inflow calls #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hkross wants to merge 10 commits into
base: rc-5.0.1
Choose a base branch
from
Draft

MHK inflow calls #3306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf1b77b
Update logic around allowable current definitions for MHK turbines
hkross Apr 13, 2026
334de00
Update r-test pointer
hkross Apr 13, 2026
e597660
Clarify that Steady Wind option cannot be used in AeroDyn driver for …
hkross Apr 13, 2026
528968b
Update r-test pointer
hkross Apr 14, 2026
4ad6e89
Merge remote tracking branch origin/rc-5.0.1 into bug/MHK_Inflow_Calls
hkross Apr 14, 2026
95622bf
Update r-test pointer
hkross Apr 14, 2026
596ffec
In SeaState, zero out the flow if a point is below the seabed
luwang00 Apr 14, 2026
1822627
Merge luwang00/b/SeaSt_Seabed into bug/MHK_Inflow_Calls
hkross Apr 14, 2026
89fade7
In SeaState, set nodeInWater to 1 for points below the seabed to prev…
luwang00 Apr 14, 2026
b3ad079
Merge luwang00/b/SeaSt_Seabed into bug/MHK_Inflow_Calls
hkross Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/aerodyn/src/AeroDyn.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,7 +1412,7 @@ subroutine Init_RotInflow( p, RotInflow, errStat, ErrMsg )
if (Failed()) return
RotInflow%Blade(k)%InflowVel = 0.0_ReKi

if (p%MHK > 0) then
if (p%MHK /= MHK_None) then
call AllocAry( RotInflow%Blade(k)%InflowAcc, 3_IntKi, p%NumBlNds, 'RotInflow%Blade(k)%InflowAcc', ErrStat2, ErrMsg2 )
if (Failed()) return
RotInflow%Blade(k)%InflowAcc = 0.0_ReKi
Expand All @@ -1422,7 +1422,7 @@ subroutine Init_RotInflow( p, RotInflow, errStat, ErrMsg )
call AllocAry( RotInflow%Tower%InflowVel, 3_IntKi, p%NumTwrNds, 'RotInflow%Tower%InflowVel', ErrStat2, ErrMsg2 ) ! could be size zero
if (Failed()) return

if (p%MHK > 0) then
if (p%MHK /= MHK_None) then
call AllocAry( RotInflow%Tower%InflowAcc, 3_IntKi, p%NumTwrNds, 'RotInflow%Tower%InflowAcc', ErrStat2, ErrMsg2 ) ! could be size zero
if (Failed()) return
end if
Expand Down Expand Up @@ -2031,7 +2031,7 @@ subroutine AD_CalcWind_Rotor(t, u, FlowField, p, p_AD, m, RotInflow, StartNode,
if (.not. associated(FlowField)) return ! use the initial (or input) values for these inputs

! If rotor is MHK, add water depth to z coordinate
if (p%MHK > 0) then
if (p%MHK /= MHK_None) then
PosOffset = [0.0_ReKi, 0.0_ReKi, p%WtrDpth]
else
PosOffset = 0.0_ReKi
Expand Down Expand Up @@ -4541,7 +4541,7 @@ SUBROUTINE ValidateInputData( InitInp, InputFileData, NumBl, calcCrvAngle, ErrSt
! .............................
! check tower mesh data:
! .............................
if (InputFileData%TwrPotent /= TwrPotent_none .or. InputFileData%TwrShadow /= TwrShadow_none .or. InputFileData%TwrAero /= TwrAero_none .or. InitInp%MHK > 0) then
if (InputFileData%TwrPotent /= TwrPotent_none .or. InputFileData%TwrShadow /= TwrShadow_none .or. InputFileData%TwrAero /= TwrAero_none .or. InitInp%MHK /= MHK_None) then
do iR = 1,size(NumBl)
if (InputFileData%rotors(iR)%NumTwrNds <= 0) cycle !bjj: this could be removed since the loops here already take into account the number of tower nodes

Expand Down
2 changes: 1 addition & 1 deletion modules/aerodyn/src/AeroDyn_Driver_Subs.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,7 +1411,7 @@ subroutine ValidateInputs(dvr, errStat, errMsg)

if (dvr%MHK /= MHK_None .and. dvr%MHK /= MHK_FixedBottom .and. dvr%MHK /= MHK_Floating) call SetErrStat(ErrID_Fatal, 'MHK switch must be 0, 1, or 2.', ErrStat, ErrMsg, RoutineName)

if (dvr%MHK /= MHK_None .and. dvr%SS_InitInp%CompSeaSt == 1 .and. dvr%IW_InitInp%CompInflow /= 1) call SetErrStat( ErrID_Fatal, 'InflowWind must be activated for MHK turbines when SeaState is used.', ErrStat, ErrMsg, RoutineName )
if (dvr%MHK /= MHK_None .and. dvr%SS_InitInp%CompSeaSt == 1 .and. dvr%IW_InitInp%CompInflow == 0 .and. dvr%IW_InitInp%HWindSpeed > 0) call SetErrStat( ErrID_Fatal, 'Steady Wind option in AeroDyn driver cannot be used for MHK turbines with SeaState.', ErrStat, ErrMsg, RoutineName )

if (dvr%MHK == MHK_None .and. dvr%SS_InitInp%CompSeaSt /= 0) call SetErrStat( ErrID_Fatal, 'SeaState cannot be used with wind turbines.', ErrStat, ErrMsg, RoutineName )

Expand Down
66 changes: 49 additions & 17 deletions modules/seastate/src/SeaSt_WaveField.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,16 @@ SUBROUTINE WaveField_GetNodeWaveKin( WaveField, WaveField_m, Time, pos, forceNod
WaveElev = WaveField_GetNodeTotalWaveElev(WaveField, WaveField_m, Time, pos, ErrStat2, ErrMsg2, Elev1=WaveElev1, Elev2=WaveElev2)
if (Failed()) return

! Check if point is below the seabed
if (pos(3)<-WaveField%EffWtrDpth) then
nodeInWater = 1_IntKi ! Prevent problems with HydroDyn logic
FV(:) = 0.0_SiKi
FA(:) = 0.0_SiKi
FDynP = 0.0_SiKi
FAMCF(:) = 0.0_SiKi
return
end if

IF (WaveField%WaveStMod == 0) THEN ! No wave stretching

IF ( pos(3) <= 0.0_ReKi) THEN ! Node is at or below the SWL
Expand All @@ -182,10 +192,10 @@ SUBROUTINE WaveField_GetNodeWaveKin( WaveField, WaveField_m, Time, pos, forceNod
END IF
ELSE ! Node is above the SWL
nodeInWater = 0_IntKi
FV(:) = 0.0
FA(:) = 0.0
FDynP = 0.0
FAMCF(:) = 0.0
FV(:) = 0.0_SiKi
FA(:) = 0.0_SiKi
FDynP = 0.0_SiKi
FAMCF(:) = 0.0_SiKi
END IF

ELSE ! Wave stretching enabled
Expand Down Expand Up @@ -251,10 +261,10 @@ SUBROUTINE WaveField_GetNodeWaveKin( WaveField, WaveField_m, Time, pos, forceNod
ELSE ! Node is out of water - zero-out all wave dynamics

nodeInWater = 0_IntKi
FV(:) = 0.0
FA(:) = 0.0
FDynP = 0.0
FAMCF(:) = 0.0
FV(:) = 0.0_SiKi
FA(:) = 0.0_SiKi
FDynP = 0.0_SiKi
FAMCF(:) = 0.0_SiKi

END IF ! If node is in or out of water

Expand Down Expand Up @@ -315,6 +325,13 @@ SUBROUTINE WaveField_GetDynP( WaveField, WaveField_m, Time, pos, forceNodeInWate
! Wave elevation (Calls WaveField_Interp_Setup3D internally so WaveField_Interp_3D_vec can be used below)
WaveElev = WaveField_GetNodeTotalWaveElev( WaveField, WaveField_m, Time, pos, ErrStat2, ErrMsg2 ); if (Failed()) return;

! Check if point is below the seabed
if (pos(3)<-WaveField%EffWtrDpth) then
nodeInWater = 1_IntKi ! Prevent problems with HydroDyn logic
FDynP = 0.0_SiKi
return
end if

IF (WaveField%WaveStMod == 0) THEN ! No wave stretching

IF ( pos(3) <= 0.0_ReKi) THEN ! Node is at or below the SWL
Expand All @@ -324,7 +341,7 @@ SUBROUTINE WaveField_GetDynP( WaveField, WaveField_m, Time, pos, forceNodeInWate
FDynP = GridInterp4D ( WaveField%WaveDynP, WaveField_m )
ELSE ! Node is above the SWL
nodeInWater = 0_IntKi
FDynP = 0.0
FDynP = 0.0_SiKi
END IF

ELSE ! Wave stretching enabled
Expand Down Expand Up @@ -365,7 +382,7 @@ SUBROUTINE WaveField_GetDynP( WaveField, WaveField_m, Time, pos, forceNodeInWate
ELSE ! Node is out of water - zero-out all wave dynamics

nodeInWater = 0_IntKi
FDynP = 0.0
FDynP = 0.0_SiKi

END IF ! If node is in or out of water
END IF ! If wave stretching is on or off
Expand Down Expand Up @@ -407,6 +424,13 @@ SUBROUTINE WaveField_GetNodeWaveVel( WaveField, WaveField_m, Time, pos, forceNod
! Wave elevation (Calls WaveField_Interp_Setup3D internally so WaveField_Interp_3D_vec can be used below)
WaveElev = WaveField_GetNodeTotalWaveElev( WaveField, WaveField_m, Time, pos, ErrStat2, ErrMsg2 ); if (Failed()) return;

! Check if point is below the seabed
if (pos(3)<-WaveField%EffWtrDpth) then
nodeInWater = 1_IntKi ! Prevent problems with HydroDyn logic
FV(:) = 0.0_SiKi
return
end if

IF (WaveField%WaveStMod == 0) THEN ! No wave stretching

IF ( pos(3) <= 0.0_ReKi) THEN ! Node is at or below the SWL
Expand All @@ -416,7 +440,7 @@ SUBROUTINE WaveField_GetNodeWaveVel( WaveField, WaveField_m, Time, pos, forceNod
FV(:) = GridInterp4DVec( WaveField%WaveVel, WaveField_m )
ELSE ! Node is above the SWL
nodeInWater = 0_IntKi
FV(:) = 0.0
FV(:) = 0.0_SiKi
END IF

ELSE ! Wave stretching enabled
Expand Down Expand Up @@ -463,7 +487,7 @@ SUBROUTINE WaveField_GetNodeWaveVel( WaveField, WaveField_m, Time, pos, forceNod
ELSE ! Node is out of water - zero-out all wave dynamics

nodeInWater = 0_IntKi
FV(:) = 0.0
FV(:) = 0.0_SiKi

END IF ! If node is in or out of water

Expand Down Expand Up @@ -520,7 +544,15 @@ SUBROUTINE WaveField_GetNodeWaveVelAcc( WaveField, WaveField_m, Time, pos, force

! Wave elevation
WaveElev = WaveField_GetNodeTotalWaveElev( WaveField, WaveField_m, Time, pos, ErrStat2, ErrMsg2 ); if (Failed()) return;


! Check if point is below the seabed
if (pos(3)<-WaveField%EffWtrDpth) then
nodeInWater = 1_IntKi ! Prevent problems with HydroDyn logic
FV(:) = 0.0_SiKi
FA(:) = 0.0_SiKi
return
end if

IF (WaveField%WaveStMod == 0) THEN ! No wave stretching

IF ( pos(3) <= 0.0_ReKi) THEN ! Node is at or below the SWL
Expand All @@ -531,8 +563,8 @@ SUBROUTINE WaveField_GetNodeWaveVelAcc( WaveField, WaveField_m, Time, pos, force
FA(:) = GridInterp4DVec( WaveField%WaveAcc, WaveField_m )
ELSE ! Node is above the SWL
nodeInWater = 0_IntKi
FV(:) = 0.0
FA(:) = 0.0
FV(:) = 0.0_SiKi
FA(:) = 0.0_SiKi
END IF

ELSE ! Wave stretching enabled
Expand Down Expand Up @@ -582,8 +614,8 @@ SUBROUTINE WaveField_GetNodeWaveVelAcc( WaveField, WaveField_m, Time, pos, force
ELSE ! Node is out of water - zero-out all wave dynamics

nodeInWater = 0_IntKi
FV(:) = 0.0
FA(:) = 0.0
FV(:) = 0.0_SiKi
FA(:) = 0.0_SiKi
END IF ! If node is in or out of water

END IF ! If wave stretching is on or off
Expand Down
9 changes: 5 additions & 4 deletions modules/seastate/src/SeaState_Input.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,11 @@ subroutine SeaStateInput_ProcessInitData( InitInp, p, InputFileData, ErrStat, Er


! CurrMod - Current profile model switch
if ( ( InputFileData%Current%CurrMod /= 0 ) .AND. ( InitInp%MHK /= MHK_None ) ) then
call SetErrStat( ErrID_Fatal,'CurrMod must be set to 0 for an MHK turbine.',ErrStat,ErrMsg,RoutineName)
return
end if

if ( InitInp%hasCurrField ) then
call SetErrStat( ErrID_Warn,'Expecting current field from InflowWind. Setting CurrMod to 0.',ErrStat,ErrMsg,RoutineName)
InputFileData%Current%CurrMod = 0
Expand All @@ -940,10 +945,6 @@ subroutine SeaStateInput_ProcessInitData( InitInp, p, InputFileData, ErrStat, Er
return
end if

! if ( ( InputFileData%Current%CurrMod /= 0 ) .AND. ( InitInp%MHK /= MHK_None ) ) then
! call SetErrStat( ErrID_Fatal,'CurrMod must be set to 0 for an MHK turbine.',ErrStat,ErrMsg,RoutineName)
! return
! end if


if ( InputFileData%Current%CurrMod == 1 ) then ! .TRUE if we have standard current.
Expand Down
2 changes: 1 addition & 1 deletion reg_tests/r-test
Open in desktop
Submodule r-test updated 4 files
+2 −2 glue-codes/openfast/MHK_RM1_Floating_Tank-scaled/FRM1Q_InflowWind.dat
+3 −3 glue-codes/openfast/MHK_RM1_Floating_Tank-scaled/FRM1Q_SeaState.dat
+1 −1 glue-codes/openfast/MHK_RM1_Floating_Tank-scaled/MHK_RM1_Floating_Tank-scaled.fst
+1 −1 modules/aerodyn/ad_MHK_RM1_Floating/MHK_RM1_Floating_SeaState.dat
Loading