Skip to content

Fix issue #84#85

Merged
lohedges merged 4 commits intodevelfrom
fix_84
Nov 21, 2025
Merged

Fix issue #84#85
lohedges merged 4 commits intodevelfrom
fix_84

Conversation

@lohedges
Copy link
Copy Markdown
Contributor

@lohedges lohedges commented Nov 20, 2025

This PR closes #84 by fixing the restart handling for GCMC simulations. The specific issues that have been resolved:

  • System comparison checks on restart now account for the fact that the checkpoint files contain additional GCMC waters.
  • The gcmc_checkpoint frequency is allowed to change between configs when it was originally None, since it will be updated to the energy_frequency in this case.
  • When re-validating the gcmc_selection for a restart, we need to account for the fact that self._system will be a list of systems.
  • I had incorrectly deleted all ghost waters from the restart system, rather than only the additional GCMC waters that are padded on the end. We need to do this so that we can set up the GCMC sampler in the normal way, following which the GCMC state of the restart is applied to the system, i.e water state and positions.
  • The final checkpoint for the regular Runner is now consistent with the others, i.e. it performs a backup and uses the lock file.

@tom-potter-cresset

@lohedges lohedges added the bug Something isn't working label Nov 20, 2025
@lohedges lohedges merged commit c5ad571 into devel Nov 21, 2025
4 checks passed
@lohedges lohedges deleted the fix_84 branch November 21, 2025 12:24
lohedges added a commit that referenced this pull request Nov 21, 2025
lohedges added a commit that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restart system comparison check doesn't account for GCMC waters

1 participant