Add support for OpenMM MonteCarloMembraneBarostat#281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the OpenMM MonteCarloMembraneBarostat, which closes #276. The functionality was patched in using the relevant commits from the PR to add the same functionality on the Cresset fork found here. (Note that their PR specifically mentions PME, but it works for non-PME too.)
Note that there are no tests for this new functionality and it is taken with the caveats mentioned by Cresset, i.e. zero surface tension, XY isotropic, and Z free. I have confirmed that all BioSimSpace tests still pass.
Other than any last minute bugfixes, this will be the last PR before the 2024.4.0 release.
develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]