Fix issue #462 #463
Merged
Fix issue #462 #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
temporarily deployed
to
biosimspace-build
GitHub Actions
Inactive
lohedges
had a problem deploying
to
biosimspace-build
GitHub Actions
Failure
mb2055
reviewed
Oct 22, 2025
| ---------- | ||
| dir : str | ||
| The path to the node library. |
Contributor
There was a problem hiding this comment.
Would be good to clarify that the path to the node directory also needs to be an absolute path
Contributor
Author
There was a problem hiding this comment.
Instead I just store the node directory as an absolute path, so it works either way. (Obviously it will be returned as an absolute path too, but this isn't an issue.)
mb2055
suggested changes
Oct 22, 2025
Contributor
mb2055
left a comment
mb2055
left a comment
There was a problem hiding this comment.
All good, but it would be good to also clarify that the path given in setNodeDirectory also needs to be absolute
lohedges
added a commit
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #462 by fixing the name of the context manager. I've also updated the docstring to state that inputs need to use absolute paths when a working directory is set, i.e. since paths will no longer be relative to the working directory of the Python process.
Also closes #449 by fixing a typo in an RDKit d2d draw option. This worked previously, so either there was a typo in the RDKit API that has been fixed, or the RDKit code no longer allows invalid attributes to be set.
develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]