Skip to content

Fix issues #426 and #427#428

Merged
lohedges merged 4 commits intodevelfrom
fix_426_427
Jul 23, 2025
Merged

Fix issues #426 and #427#428
lohedges merged 4 commits intodevelfrom
fix_426_427

Conversation

@lohedges
Copy link
Contributor

This PR fixes closes issue #426 and closes #427. The fix for #426 isn't ideal, but is probably all we can do until the issue is properly fixed upstream.

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@lohedges lohedges requested a review from xiki-tempula July 22, 2025 17:29
@lohedges lohedges added the bug Something isn't working label Jul 22, 2025
@lohedges lohedges had a problem deploying to biosimspace-build July 22, 2025 17:30 — with GitHub Actions Failure
@lohedges lohedges had a problem deploying to biosimspace-build July 22, 2025 17:30 — with GitHub Actions Failure
@lohedges lohedges had a problem deploying to biosimspace-build July 22, 2025 17:30 — with GitHub Actions Failure
@lohedges lohedges had a problem deploying to biosimspace-build July 22, 2025 17:30 — with GitHub Actions Failure
@lohedges lohedges had a problem deploying to biosimspace-build July 22, 2025 17:30 — with GitHub Actions Failure
@lohedges lohedges temporarily deployed to biosimspace-build July 22, 2025 18:22 — with GitHub Actions Inactive
@lohedges lohedges had a problem deploying to biosimspace-build July 22, 2025 18:22 — with GitHub Actions Failure
@lohedges lohedges temporarily deployed to biosimspace-build July 22, 2025 18:22 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 22, 2025 18:22 — with GitHub Actions Inactive
@lohedges lohedges temporarily deployed to biosimspace-build July 22, 2025 18:22 — with GitHub Actions Inactive
Copy link
Collaborator

@xiki-tempula xiki-tempula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks sensible but is not my issue

@lohedges lohedges merged commit e51a855 into devel Jul 23, 2025
4 of 5 checks passed
@lohedges lohedges deleted the fix_426_427 branch July 23, 2025 08:18
lohedges added a commit that referenced this pull request Jul 23, 2025
@lohedges lohedges added the recursion Related to work with Recursion label Jul 23, 2025
lohedges added a commit that referenced this pull request Jul 23, 2025
@lohedges lohedges mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working recursion Related to work with Recursion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Don't explicitly require AnteChamber when OpenFF-NAGL is installed

2 participants