fix(AppAlert): prevent layout shift on initial render for new users#1453
Open
devjhex wants to merge 1 commit intoOpenBeta:developfrom
Open
fix(AppAlert): prevent layout shift on initial render for new users#1453devjhex wants to merge 1 commit intoOpenBeta:developfrom
devjhex wants to merge 1 commit intoOpenBeta:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Create a pull request
title: 'Fix layout shift for main alert component'
labels: 'bug fix'
assignees: ''
What type of PR is this?(check all applicable)
Description
What this PR achieves
AppAlert was initializing with
useState(false)which caused a layout shift for every first-time visitor. Since useEffect runs after the first render, the alert would always pop in after the page painted, pushing content down.Changing to
useState(true)means the alert renders visible from the start — no shift for new users. The only tradeoff is a brief flash for returning users who already dismissed it (cookie exists), but this is barely noticeable especially on fast devices and affects a much smaller group.Related Issues
Issue #1452
Screenshots, recordings
Illustration
Notes