fix(mediorum): stop terminal transcode retries#338
Open
RolfAris wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some bad audio uploads are retried indefinitely by the missed-transcode backlog.
The retry loop is:
status IN ('new', 'error'),error_count <= 5busyupload updateerrorupload updateThat keeps producing full-row
uploads/updateCRUD ops for uploads that already failed repeatedly and do not have a320transcode result.Change
Stop selecting terminal transcode failures once
error_count >= 5and there is still no320result.Also guard
transcode()itself before writing thebusystate, so an over-limit upload cannot produce another transient write if it reaches the worker through another path.Audio-analysis backlog selection now skips the same terminal transcode failures unless a
320result exists.Evidence
The source cap is necessary but not sufficient by itself.
In the canary,
val008ran the source-side retry cap without the receiver-side suppression. Itsuploads/updategrowth stayed essentially flat versus its own pre baseline:That is
-2.07%rows and+0.01%bytes in the latest 1h sample. Across 20 clean hourly samples, source-only averaged-0.47%rows and-0.53%bytes, so it did not materially reduce validatoropsgrowth.This PR still matters because upgraded nodes should stop producing local terminal retry churn. The material validator-wide reduction requires pairing this with receiver-side suppression of legacy remote retry ops.
Tests