Add configurable More tab for white-label apps via OBAKitConfig.MoreTab#1104
Open
diveshpatil9104 wants to merge 1 commit intoOneBusAway:mainfrom
Open
Add configurable More tab for white-label apps via OBAKitConfig.MoreTab#1104diveshpatil9104 wants to merge 1 commit intoOneBusAway:mainfrom
diveshpatil9104 wants to merge 1 commit intoOneBusAway:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds white-label customization for the More/Settings tab via
OBAKitConfig.MoreTabinproject.yml, addressing #666 and #614.Agencies can now configure:
Also fixes pre-existing issues:
[weak self](retain cycle risk)Bundle.main.appNameChanges
OBAKitCore/Models/MoreTab/MoreTabConfiguration.swiftOBAKitCore/Extensions/FoundationExtensions.swiftmoreTabConfigurationOBAKit/Settings/MoreViewController.swift[weak self]fixesOBAKit/Settings/MoreHeaderController.swiftApps/OneBusAway/project.ymlApps/KiedyBus/project.ymlOBAKitTests/Modeling/MoreTabConfigurationTests.swiftExample Config (KiedyBus)
Design Decisions
donationsConfigpattern — no new architecture, just extendsOBAKitConfigcompactMapfor malformed links