Update video_analysis_per_frame.py#402
Open
rEufrazio wants to merge 1 commit intoOlafenwaMoses:masterfrom
Open
Update video_analysis_per_frame.py#402rEufrazio wants to merge 1 commit intoOlafenwaMoses:masterfrom
rEufrazio wants to merge 1 commit intoOlafenwaMoses:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 49.96% 49.96%
=======================================
Files 63 63
Lines 5856 5856
=======================================
Hits 2926 2926
Misses 2930 2930 |
rola93
approved these changes
Feb 10, 2020
| if (resized == False): | ||
| manager = plt.get_current_fig_manager() | ||
| manager.resize(width=1000, height=500) | ||
| manager.resize(1000, 500) |
Contributor
There was a problem hiding this comment.
It looks like newer versions on matplotlib renamed this parameter. According to the current docs available, parameters are w and h. Maybe they were different when @OlafenwaMoses wrote this code. One more reason to fix libraries versions on requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manager.resize() method does not expect width and height parameters.