Add all temperatures to websocket for future use#1
Draft
TheSin- wants to merge 6 commits intoOctoPrint:mainfrom
Draft
Add all temperatures to websocket for future use#1TheSin- wants to merge 6 commits intoOctoPrint:mainfrom
TheSin- wants to merge 6 commits intoOctoPrint:mainfrom
Conversation
- Add tools if you have more set in the printer profile - Add a few variants for chamber like cavity (jneilii firmware uses it) - Add TMC2240 temperatures, since most TMCs do not support temp, limit to list (temps do not show unless the driver is energizes, so add `or 0` since it will return None when it's not energized. I'm not sure what others drivers should be added so I only added 2240, but it's easy to add to it.
…w way to tell the connector that a new list of temperatures names is available
…isable based on state?
TheSin-
force-pushed
the
main
branch
3 times, most recently
from
82d192f to
fa45d54
Compare
jneilliii
reviewed
Dec 18, 2025
|
|
||
| self.btnKlipperRestartClick = function() { | ||
| showConfirmationDialog({ | ||
| message: gettext("<strong>This will restart the Klipper service.</strong></p><p>This might disrupt any ongoing operations related to Klipper."), |
There was a problem hiding this comment.
gettext should not include html whatsoever I'm pretty sure, it would interfere with the ability to translate I think.
Author
There was a problem hiding this comment.
100% agree I missed that, thanks I’ll fix it tomorrow when I keep trying to solve my other issues ;)
Author
There was a problem hiding this comment.
should be solved in 2e447bb
Still not used to having 2 accounts :\
…ich isn't usable when connecting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
or 0since it will return None when it's not energized. I'm not sure what others drivers should be added so I only added 2240, but it's easy to add to it.NOTES:
TODO:
FIRMWARE_RESTARTorRESTARTit rereads and rebuilds as the sensor could have changed, haven't tested this yet to make sure. The both lists might need to be reset when system firmware is triggered?gcode_idparameter, this indicated to KlipperScreen and other UIs to graph/display that temp, maybe we can find a way to only get those, sadly that value wasn't present in the object query.FIRMWARE_RESTARTorRESTART(uses moonraker post instead of WS, incase WS isn't ready)FUTURE PRs:
gcodesbut this value can be changed in the klipper config, we might want to see if we can get the value, I haven't checked the moon raker api to see if it's fetch able yet, but wanted to log it.MAYBE AN OTHER PLUGIN??