Conversation
|
Hi @sydseter, all checks have passed. Kindly review this PR |
|
I’ll test this and get back to you. |
|
Thank you for all your efforts. |
|
Great experience working in this repo. |
|
@Mysterio-17 Could you update your commits so that they have a verified signature? ref: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
0d9bd49 to
b91812e
Compare
|
@sydseter, I've updated my commits with a verified signature. You may review it and merge the same |
|
@Mysterio-17 Thank you for this. Could you make sure the build is passing as well? |
|
@sydseter, Yes I've fixed the build tests, you may review the PR |
|
@Mysterio-17 Great! If you want you can add yourself to the contributor list: https://github.com/OWASP/cornucopia/blob/master/cornucopia.owasp.org/data/website/pages/about/en/index.md#volunteers The list is alphabetical. |
|
@Mysterio-17 could you delete the lock file and recreate it. There is a conflict. Also: If you want you can add yourself to the contributor list: https://github.com/OWASP/cornucopia/blob/master/cornucopia.owasp.org/data/website/pages/about/en/index.md#volunteers |
|
@sydseter, I've implemented the lock file again and checked the tests, also added my name in the contributor list. |
|
@sydseter, i ran all the tests again locally and verified them. Can you kindly run the checks again |
Signed-off-by: Mradul Tiwari <[email protected]>
|
@sydseter , I rectified the names' order. |
|
@Mysterio-17, you need to run pnpm install and submit the lockfile again, as the changes you merged from master require the lock file to be regenerated to be valid. |
|
@sydseter, I modified the lockfile again and checked for tests locally |
Description
Upgrades Vite from 5.4.21 to 7.3.1 as per the latest release.
Changes
5.4.21→7.3.14.0.4→6.2.4(required for Vite 7 compatibility)3.2.4→4.0.17(Vite 7 compatible)Testing
Notes
Related