Skip to content

Fix #1901: Install system dependencies for lxml in workflow and Docker #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7uyash wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

Fix #1901: Install system dependencies for lxml in workflow and Docker #2006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/publishing-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: '3.12'

- name: Install system dependencies for lxml
run: sudo apt-get update && sudo apt-get install -y libxml2-dev libxslt1-dev
Comment on lines +19 to +20
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title references issue #1901, but the description and commits reference issue #1990. Please verify which is the correct issue number and update the title accordingly to ensure proper issue tracking and linking.

Copilot uses AI. Check for mistakes.
- name: Install Python dependencies
run: make install-python-requirements
- name: Build website
Expand Down
8 changes: 8 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
FROM python:latest
WORKDIR /usr/src/app

RUN apt-get update && apt-get install -y \
build-essential \
gcc \
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile includes gcc explicitly on line 6, but gcc is already included in the build-essential package on line 5. This creates redundancy. Consider removing the explicit gcc line since it's already provided by build-essential.

Suggested change
gcc \

Copilot uses AI. Check for mistakes.
libxml2-dev \
libxslt1-dev \
zlib1g-dev \
&& rm -rf /var/lib/apt/lists/*

COPY requirements.txt Makefile ./
RUN make install-python-requirements

Expand Down