10k Bus Case#461
Draft
lukelowry wants to merge 42 commits into
Draft
Conversation
…or' into lukel/tenK-dev
…o lukel/tenK-dev # Conflicts: # GridKit/Model/PhasorDynamics/INPUT_FORMAT.md
…-dev # Conflicts: # GridKit/Model/PhasorDynamics/INPUT_FORMAT.md
…K-dev # Conflicts: # CHANGELOG.md # GridKit/Model/PhasorDynamics/ComponentLibrary.hpp # GridKit/Model/PhasorDynamics/Converter/CMakeLists.txt # GridKit/Model/PhasorDynamics/INPUT_FORMAT.md # GridKit/Model/PhasorDynamics/SystemModelData.hpp # GridKit/Model/PhasorDynamics/SystemModelDataJSONParser.hpp # GridKit/Model/PhasorDynamics/SystemModelImpl.hpp # tests/UnitTests/PhasorDynamics/CMakeLists.txt
…-dev # Conflicts: # CHANGELOG.md # GridKit/Model/PhasorDynamics/ComponentLibrary.hpp # GridKit/Model/PhasorDynamics/Converter/CMakeLists.txt # GridKit/Model/PhasorDynamics/Converter/README.md # GridKit/Model/PhasorDynamics/INPUT_FORMAT.md # GridKit/Model/PhasorDynamics/SystemModelData.hpp # GridKit/Model/PhasorDynamics/SystemModelDataJSONParser.hpp # GridKit/Model/PhasorDynamics/SystemModelImpl.hpp # docs/GridKit/Model/PhasorDynamics/Converter/README.md # tests/UnitTests/PhasorDynamics/CMakeLists.txt
…K-dev # Conflicts: # GridKit/Model/PhasorDynamics/ComponentLibrary.hpp # GridKit/Model/PhasorDynamics/SystemModelData.hpp
…nK-dev # Conflicts: # CHANGELOG.md # GridKit/Model/PhasorDynamics/INPUT_FORMAT.md # GridKit/Model/PhasorDynamics/SystemModelData.hpp
…-dev # Conflicts: # CHANGELOG.md # GridKit/Model/PhasorDynamics/ComponentLibrary.hpp # GridKit/Model/PhasorDynamics/Governor/CMakeLists.txt # GridKit/Model/PhasorDynamics/Governor/README.md # GridKit/Model/PhasorDynamics/INPUT_FORMAT.md # GridKit/Model/PhasorDynamics/SystemModelData.hpp # GridKit/Model/PhasorDynamics/SystemModelDataJSONParser.hpp # GridKit/Model/PhasorDynamics/SystemModelImpl.hpp # docs/GridKit/Model/PhasorDynamics/Governor/README.md # tests/UnitTests/PhasorDynamics/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ACTIVSg10k. A few models, which are documented but not implemented, are given a substitute model
Requires #415 #419 #421 #420 #422 #424 #460 #439 #438
Much faster than I thought it would be. Nearly real-time, and this is with the IBR models
PowerWorld: 16.281 sec
GridKit: 8.774 sec
PowerWorld doesn't initialize correctly either, but GridKit does!
Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
I also got the ACTIVSg25k bus to run on the first try, but more than 1/2 a second of output filled my hard drive, so we should be careful about what we include as monitored fields!
I will rewrite the branch history but I had to do merges into this branch to test it out with all the fixes and models.