Expand Collection of Segment Level RFT Output Arrays#5119
Draft
bska wants to merge 1 commit intoOPM:masterfrom
Draft
Expand Collection of Segment Level RFT Output Arrays#5119bska wants to merge 1 commit intoOPM:masterfrom
bska wants to merge 1 commit intoOPM:masterfrom
Conversation
bska
added
the
manual:new-feature
Member
Author
|
I'm creating this PR in draft mode for several reasons
I will keep the PR in a draft state until such time as it is ready for review and merging. |
bska
force-pushed
the
more-icd-rft-arrays
branch
4 times, most recently
from
a40e2dd to
d487d90
Compare
bska
force-pushed
the
more-icd-rft-arrays
branch
3 times, most recently
from
031b54a to
c7440e5
Compare
This commit introduces three new (static) segment level output
arrays in the RFT file. Each of these arrays are sized according to
the number of segments. Regular segments and valves (defined by
keyword WSEGVALV) get zero-valued entries, whereas inflow control
devices (keywords WSEGAICD and WSEGSICD) get non-zero values.
* SEGLEN is the ICD's length along the segment
* SEGQICD is the ICD's maximum absolute flow rate
* SEGFSCAL is the ICD's effective scaling factor
(SICD::scalingFactor(), calculated by updateScalingFactor())
bska
force-pushed
the
more-icd-rft-arrays
branch
from
c7440e5 to
1598109
Compare
Member
Author
|
jenkins build this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces three new (static) segment level output arrays in the RFT file. Each of these arrays are sized according to the number of segments. Regular segments and valves (defined by keyword
WSEGVALV) get zero-valued entries, whereas inflow control devices (keywordsWSEGAICDandWSEGSICD) get non-zero values.SICD::scalingFactor(), calculated byupdateScalingFactor())