Improve description of statistical formulas#13567
Merged
Conversation
kriben
requested changes
Feb 6, 2026
magnesj
force-pushed
the
improve-usability-statistical-functions
branch
from
11cdbbc to
d0cde69
Compare
jonjenssen
reviewed
Feb 6, 2026
jonjenssen
reviewed
Feb 6, 2026
jonjenssen
reviewed
Feb 6, 2026
jonjenssen
requested changes
Feb 6, 2026
Collaborator
jonjenssen
left a comment
jonjenssen
left a comment
There was a problem hiding this comment.
Maybe look for an alternative to asserts to avoid ResInsight crashing in release?
Refactored percentile and quantile calculation logic for improved flexibility and maintainability. Added helper functions for quantile/percentile validation, introduced a new vector-based calculatePercentiles method, and updated calculateStatisticsCurves to use it. Refactored nearest-rank and interpolated percentile methods to accept percentiles as vectors and improved parameter validation. Enhanced documentation throughout and updated function signatures in the header for clarity.
magnesj
force-pushed
the
improve-usability-statistical-functions
branch
from
058506e to
12cfee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a general function to compute percentiles. Add detailed description of the formulas used to compute statistical values. Existing API is unchanged.
Use quantile for values in range [0..1] and percentile for values in range [0..100]
Preparations for #13175