Skip to content

Prune extra decoded children that should stay on the type definition only.#3843

Merged
mrsuciu merged 3 commits into
OPCFoundation:master378from
mrsuciu:master378-PruneNonOptionalAndMandatory
Jun 17, 2026
Merged

Prune extra decoded children that should stay on the type definition only.#3843
mrsuciu merged 3 commits into
OPCFoundation:master378from
mrsuciu:master378-PruneNonOptionalAndMandatory

Conversation

@mrsuciu

@mrsuciu mrsuciu commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Keep the generated children that belong on instances, and prune the extra decoded children that should stay on the type definition only, such as Optional/Mandatory placeholders and ones that do not have Mandatory/Optional ModellingRules.

Description

Currently child nodes that are type definition detailes such as ones that do not have Mandatory/Optional ModellingRules are instantiated in the runtime instance of such type definitions. This PR proposes to correct this behaviour during NodeState creation as an alternative from it being fixed by the ModelCompiler.

Related Issues

Checklist

Put an x in the boxes that apply. You can complete these step by step after opening the PR.

  • I have signed the CLA and read the CONTRIBUTING doc.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added all necessary documentation.
  • I have verified that my changes do not introduce (new) build or analyzer warnings.
  • I ran all tests locally using the UA.slnx solution against at least .net framework and .net 10, and all passed.
  • I fixed all failing and flaky tests in the CI pipelines and all CodeQL warnings.
  • I have addressed all PR feedback received.

mrsuciu and others added 2 commits June 4, 2026 17:48
…xtra decoded children that should stay on the type definition such as Optional/Mandatory placeholders and ones that do not have Mandatory/Optional ModellingRules.
@marcschier marcschier added the 1.5.378 Only affects 1.5.378 (pre 2.0) label Jun 9, 2026
@mrsuciu mrsuciu marked this pull request as ready for review June 16, 2026 09:20
@mrsuciu mrsuciu merged commit 00519fa into OPCFoundation:master378 Jun 17, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.5.378 Only affects 1.5.378 (pre 2.0)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProgramStateMachineState has wrong InitializationString and possible many other classes also

3 participants