plat-qcom: Add support for lemans SoC#7708
Conversation
|
FYI @ldts |
ldts
left a comment
There was a problem hiding this comment.
LGTM, just a suggestion in preparation for more platforms
| /* Make stacks aligned to data cache line length */ | ||
| #define STACK_ALIGNMENT 64 | ||
|
|
||
| #if defined(PLATFORM_FLAVOR_kodiak) || defined(PLATFORM_FLAVOR_lemans) |
There was a problem hiding this comment.
I know it is probably still early but shouldnt we create a configs/ folder and simply include the folder for the platform (instead of defining the registers here). I think we will scale better.
There was a problem hiding this comment.
regardless
Reviewed-by: Jorge Ramirez-Ortiz <[email protected]>
There was a problem hiding this comment.
I know it is probably still early but shouldnt we create a configs/ folder and simply include the folder for the platform (instead of defining the registers here). I think we will scale better.
I do agree with that but still as you said it's bit early now as we need more configs and platforms support to see the commonalities and differences to lay out proper abstractions here.
Add support for lemans SoC with platform support tested on lemans EVK platform also known as Qualcomm Dragonwing IQ-9075. More information regarding this platform can be found here [1]. [1] https://www.qualcomm.com/internet-of-things/products/iq9-series/iq-9075 Reviewed-by: Jorge Ramirez-Ortiz <[email protected]> Signed-off-by: Sumit Garg <[email protected]>
6162db4 to
5533654
Compare
|
Tag applied, thanks. |
|
Added additional patch to add CI build target for lemans SoC. |
|
For "ci: qcom: add lemans platform build", please apply: |
Add PLATFORM=qcom-lemans build. Acked-by: Jens Wiklander <[email protected]> Signed-off-by: Sumit Garg <[email protected]>
36f73ce to
d87ee17
Compare
|
Tag applied, thanks. |
Add support for lemans SoC with platform support tested on lemans EVK platform also known as Qualcomm Dragonwing IQ-9075. More information regarding this platform can be found here [1].
[1] https://www.qualcomm.com/internet-of-things/products/iq9-series/iq-9075
Corresponding TF-A gerrit review is here: https://review.trustedfirmware.org/q/topic:%22qti_lemans_evk%22