Skip to content

fix: prevent black viewport when navigating series with client-created segmentation #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbocce merged 5 commits into from
Mar 28, 2026
+44 −4
Merged

fix: prevent black viewport when navigating series with client-created segmentation #5919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37c11c6
fix: skip client-created segmentation display sets during Page Down n…
GhadeerAlbattarni Mar 25, 2026
cb0fafc
test(e2e): add a test for Page Down series navigation after creating …
GhadeerAlbattarni Mar 25, 2026
2b61388
Merge remote-tracking branch 'upstream/master' into fix/5888-segmenta…
GhadeerAlbattarni Mar 27, 2026
9ec1fbe
apply PR feedback
GhadeerAlbattarni Mar 27, 2026
f759310
improve readability of segmentation series navigation test
GhadeerAlbattarni Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions extensions/default/src/commandsModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,10 +734,11 @@ const commandsModule = ({
displaySetIndexToShow > -1 && displaySetIndexToShow < currentDisplaySets.length;
displaySetIndexToShow += direction
) {
if (
!excludeNonImageModalities ||
!nonImageModalities.includes(currentDisplaySets[displaySetIndexToShow].Modality)
) {
const nextDisplaySet = currentDisplaySets[displaySetIndexToShow];
if (nextDisplaySet.madeInClient) {
continue;
}
if (!excludeNonImageModalities || !nonImageModalities.includes(nextDisplaySet.Modality)) {
break;
}
}
Expand Down
39 changes: 39 additions & 0 deletions tests/SegmentationSeriesNavigation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { test, visitStudy, expect } from './utils';
import { press } from './utils/keyboardUtils';

test.beforeEach(async ({ page }) => {
const studyInstanceUID = '1.2.840.113619.2.290.3.3767434740.226.1600859119.501';
const mode = 'segmentation';
await visitStudy(page, studyInstanceUID, mode, 2000);
});

test('should keep the viewport rendered when navigating series with Page Down after adding a segmentation', async ({
page,
leftPanelPageObject,
rightPanelPageObject,
viewportPageObject,
}) => {
// Study has 5 series; pressing 8 times verifies navigation remains stable even after
// reaching the client-created SEG display set appended by "Add Segmentation".
const minimumSeriesExpected = 5;
const totalPageDownPresses = minimumSeriesExpected + 3;

await rightPanelPageObject.labelMapSegmentationPanel.addSegmentationButton.click();

const thumbnailsLocator = leftPanelPageObject.thumbnails;
await expect
.poll(async () => {
return await thumbnailsLocator.count();
})
.toBeGreaterThanOrEqual(minimumSeriesExpected);

const activeViewport = await viewportPageObject.active;
await activeViewport.pane.click();
await activeViewport.pane.dblclick();

for (let i = 0; i < totalPageDownPresses; i++) {
await press({ page, key: 'PageDown' });
const currentActiveViewport = await viewportPageObject.active;
await expect(currentActiveViewport.overlayText.bottomRight.instanceNumber).toBeVisible();
}
});
Loading