add datamodificationexception class#914
Draft
ElizabethOkerio wants to merge 3 commits intoOData:release-8.xfrom
Draft
add datamodificationexception class#914ElizabethOkerio wants to merge 3 commits intoOData:release-8.xfrom
ElizabethOkerio wants to merge 3 commits intoOData:release-8.xfrom
Conversation
xuzhg
requested changes
May 15, 2023
| /// Identifies a container for holding instance annotations. A default implementation is provided. | ||
| /// Customers can have their own implementation. | ||
| /// </summary> | ||
| public interface IODataInstanceAnnotationContainer |
Member
There was a problem hiding this comment.
Actually, I don't like this interface and the methods defined.
Contributor
Author
There was a problem hiding this comment.
What do you suggest it be replaced with?
| /// <summary> | ||
| /// Gets or sets the annotation container to hold transient instance annotations. | ||
| /// </summary> | ||
| IODataInstanceAnnotationContainer TransientInstanceAnnotationContainer { get; set; } |
Member
There was a problem hiding this comment.
where and how can customer set this interface?
Contributor
Author
There was a problem hiding this comment.
when they are creating the response. If there are operations in the DeltaSet that failed then you need to create DataModificationExceptions. This is the time customers will need this interface.
| public abstract DeltaItemKind Kind { get; } | ||
|
|
||
| /// <inheritdoc/> | ||
| public IODataInstanceAnnotationContainer TransientInstanceAnnotationContainer { get => throw new NotImplementedException(); set => throw new NotImplementedException(); } |
Member
There was a problem hiding this comment.
Can we mark it abstract and remove NotImplementedException()?
or at least the exception contains the message
ElizabethOkerio
force-pushed
the
feature/add_data_modification_class
branch
from
dc650e0 to
d73d3af
Compare
|
Please add a description of what this Pr does and what problem it is trying to address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.