Set the time zone in ODataQuerySettings from the request context#1403
Open
icnocop wants to merge 3 commits intoOData:mainfrom
Open
Set the time zone in ODataQuerySettings from the request context#1403icnocop wants to merge 3 commits intoOData:mainfrom
icnocop wants to merge 3 commits intoOData:mainfrom
Conversation
WanjohiSammy
reviewed
Feb 6, 2025
test/Microsoft.AspNetCore.OData.Tests/Query/Query/ODataQueryContextExtensionsTests.cs
Outdated
Show resolved
Hide resolved
Member
|
Please add an End-to-End test with this scenario: |
WanjohiSammy
requested review from
DButoyez,
Copilot,
emmanuel-karanja,
gathogojr,
habbes,
marabooy and
xuzhg
…ntextExtensionsTests.cs
WanjohiSammy
reviewed
Feb 9, 2025
| returnSettings.CopyFrom(settings); | ||
| } | ||
|
|
||
| returnSettings.TimeZone ??= context.Request.GetTimeZoneInfo(); |
Member
There was a problem hiding this comment.
Would you like to place this line of code before the copyFrom during the initialization of returnSettings?
The change you've suggested will always override the copyFrom action. Please note that null is a valid value, and users might choose to set returnSettings.TimeZone to null.
|
Has this been addressed in #1546? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384