refactor: extract util package from main.go #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract TrimQuotes, FixEscapeQuotes, and Contains utility functions to internal/util package with full test coverage.
The Contains function was dead code - the original was never called, and the wrapper just delegated to slices.Contains which is available in the standard library since Go 1.21.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TrimQuotes,FixEscapeQuotes, andContainsutility functions tointernal/utilpackagestrings.ReplaceAll,slices.Contains)Changes
internal/util/util.gowith exported utility functionsinternal/util/util_test.gowith full test coveragecmd/ocap_recorder/main.goto useutil.*functionsTest plan
go test ./internal/util/...)go build ./cmd/ocap_recorder/...)