Skip to content

[19.0][MIG] Migration of module base_external_dbsource_mssql#416

Open
alan196 wants to merge 22 commits intoOCA:19.0from
Jarsa-dev:19.0-mig-base_external_dbsource_mssql
Open

[19.0][MIG] Migration of module base_external_dbsource_mssql#416
alan196 wants to merge 22 commits intoOCA:19.0from
Jarsa-dev:19.0-mig-base_external_dbsource_mssql

Conversation

@alan196
Copy link
Contributor

@alan196 alan196 commented Feb 1, 2026

This PR depends on #415

lasley and others added 22 commits February 1, 2026 15:29
* Heavily refactor code for reusability
* Split all sources into independent modules
* Add more test coverage
* Add CRUD methods
* Add iterator execute return to roadmap

[UPD] Update base_external_dbsource_mssql.pot
[UPD] README.rst

[UPD] Update base_external_dbsource_mssql.pot

[UPD] README.rst
[UPD] Update base_external_dbsource_mssql.pot
[UPD] Update base_external_dbsource_mssql.pot
…heel for pymssql" (OCA#196)

The new `pymssql==2.2.6` version released this weekend
  - <img width="414" alt="Screenshot 2022-11-15 at 20 11 53" src="https://user-images.githubusercontent.com/6644187/202066666-a1551d22-d50a-4c14-ae0a-dd35dc147a40.png">

requires extra setup to be installed

So, it is raising new errors where it is not setup

You can reproduce it running the following command:

    docker run -it --rm  python:3.6 pip3 install -q pymssql==2.2.6

`ERROR: Could not build wheels for pymssql...`

  ERROR: Command errored out with exit status 1:
    command: /usr/local/bin/python /usr/local/lib/python3.6/site-packages/pip/_vendor/pep517/in_process/_in_process.py build_wheel /tmp/tmpmp6b33ly
        cwd: /tmp/pip-install-p4ocn1ip/pymssql_01748f191a744758bda6f7d536f6ec35
    Complete output (25 lines):
    setup.py: platform.system() => Linux
    setup.py: platform.architecture() => ('64bit', 'ELF')
    setup.py: platform.libc_ver() => ('glibc', '2.2.5')
    setup.py: include_dirs => []
    setup.py: library_dirs => []
    running bdist_wheel
    running build
    running build_py
    creating build
    creating build/lib.linux-x86_64-3.6
    creating build/lib.linux-x86_64-3.6/pymssql
    copying src/pymssql/__init__.py -> build/lib.linux-x86_64-3.6/pymssql
    running build_ext
    cythoning src/pymssql/_mssql.pyx to src/pymssql/_mssql.c
    cythoning src/pymssql/_pymssql.pyx to src/pymssql/_pymssql.c
    building 'pymssql._mssql' extension
    creating build/temp.linux-x86_64-3.6
    creating build/temp.linux-x86_64-3.6/src
    creating build/temp.linux-x86_64-3.6/src/pymssql
    gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.6m -c src/pymssql/_mssql.c -o build/temp.linux-x86_64-3.6/src/pymssql/_mssql.o -DMSDBLIB
    src/pymssql/_mssql.c:747:10: fatal error: sqlfront.h: No such file or directory
      747 | #include "sqlfront.h"
          |          ^~~~~~~~~~~~
    compilation terminated.
    error: command 'gcc' failed with exit status 1
    ----------------------------------------
    ERROR: Failed building wheel for pymssql
  ERROR: Could not build wheels for pymssql which use PEP 517 and cannot be installed directly
  WARNING: You are using pip version 21.2.4; however, version 21.3.1 is available.
  You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
  FAIL

However, using

    docker run -it --rm  python:3.6 pip3 install -q pymssql==2.2.5

It is installing well!

So, I have created this PR in order to fix all the error in the CI using this project and installing this package
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-16.0/server-backend-16.0-base_external_dbsource_mssql
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_external_dbsource_mssql/
Currently translated at 100.0% (4 of 4 strings)

Translation: server-backend-16.0/server-backend-16.0-base_external_dbsource_mssql
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_external_dbsource_mssql/es/
Currently translated at 100.0% (4 of 4 strings)

Translation: server-backend-16.0/server-backend-16.0-base_external_dbsource_mssql
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_external_dbsource_mssql/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: server-backend-16.0/server-backend-16.0-base_external_dbsource_mssql
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_external_dbsource_mssql/pt_BR/
@alan196 alan196 mentioned this pull request Feb 1, 2026
7 tasks
@CRogos
Copy link
Contributor

CRogos commented Feb 2, 2026

@alan196 could you check if pymssql is also working in version 2.2.10 ?

This module currently breaks all odoo.sh installations #394

This would work on odoo.sh:
pymssql<=2.2.10 ; python_version > '3.10'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.