[18.0][ADD] hr_collective_agreement_partner

[Anxo82]

@HaraldPanten @Jaimermaccione

• This module depends on the hr_collective_agreement module ([18.0][ADD] hr_collective_agreement #1544)

• [T-8786]

[NL66278]

👍 Thank you also for this module. Again a few changes would help adoption.

[Anxo82]

@NL66278 the ir.actions.act_window has been moved to its own XML file, and inherited views now keep the original XML-IDs, with the view name updated to include the module name as suggested.
Thanks.

[NL66278]

👍 LGTM

[Jaimermaccione]

@Anxo82
The module has been reviewed functionally in a local environment.

The link between company-type partners and collective agreements has been tested and works as expected.

Contact smart button

As a possible improvement, assuming the current access flow is kept (only HR / HR Admin users can create or edit collective agreements), it may be worth adjusting the behavior of the smart button on contacts:

• The smart button should also be visible when the company has 0 linked agreements, allowing any user (or users with contact permissions) to assign an already existing agreement.
• From this list, users should not be able to create new agreements, only link an existing one.

If this approach is technically feasible, it would provide a more consistent user experience and reduce confusion between creating agreements and assigning them.

README – usage section

As an additional improvement, it would be good to review and enhance the README usage section.
Based on the changes that may be introduced following these requests, the README could include a clearer and more explicit “usage” section for the module.

Thank you!

[Anxo82]

@Jaimermaccione Changes applied.
The smart button is now always visible on the partner form. From the partner’s collective agreements list, existing agreements can be assigned through a dedicated wizard.
Could you review it again?
Thanks

[Jaimermaccione]

@Anxo82 I have tested the new changes and the behavior matches my expectations.

I have a couple of comments:

1. README – "Authorized users"

In the README you mention:

From the collective agreements list of a contact, authorized users can assign additional collective agreements using the “Select Agreement” button.

Is this restricted to a specific user group? I have not detected any particular access restriction.

I think it is fine if any internal user can assign a collective agreement. If there is no actual group limitation, it might be better to remove the reference to “authorized users” from the README to avoid confusion.

---

2. Existing assignments are preserved

When it states:

Existing assignments are preserved.

I understand that collective agreements cannot be unlinked from this view, correct?

Would it be possible to add a column allowing users to unlink them? In other standard Odoo models, there is usually a column with an “X” or a trash icon to remove the relation.

I believe it would be appropriate for a user to be able to manage the unlinking of a collective agreement from a contact as well.

Please review this and assess whether the implementation would be reasonably simple.

---

Thank you.

[Anxo82]

@Jaimermaccione changes done. Could you review it again?
Thanks

[Jaimermaccione]

@Anxo82 I have functionally reviewed the previously discussed changes in a local environment.

The updates have been correctly implemented. It is now possible to remove collective agreements from contacts that already have them assigned.

Additionally, the README wording has been improved to avoid confusion regarding user permissions.

Everything has been verified and works as expected.

LGTM 👍

Thank you!