feat(tests): add JSON Schema test coverage#286
feat(tests): add JSON Schema test coverage#286frankkilcommins merged 1 commit intoOAI:v1.0.0-devfrom
Conversation
jeremyfiel
force-pushed
the
feat/schema-test-coverage
branch
3 times, most recently
from
af5f4af to
7263e27
Compare
|
rebased on v1.0.0-dev to resolve conflicts. |
ralfhandl
left a comment
ralfhandl
left a comment
There was a problem hiding this comment.
@jeremyfiel Why is the specification markdown source changed by this PR?
|
Markdown lint was added and the rebase onto v1.0.0-dev included some recent updates by Frank I didn't change any wording on it |
|
I would separate these changes into two separate pull requests:
|
jeremyfiel
force-pushed
the
feat/schema-test-coverage
branch
from
7263e27 to
45d61f5
Compare
|
jeremyfiel
force-pushed
the
feat/schema-test-coverage
branch
2 times, most recently
from
fc6b037 to
8b2dc94
Compare
jeremyfiel
left a comment
jeremyfiel
left a comment
There was a problem hiding this comment.
mistakenly removed the original validate-markdown.yaml with mdv checks.
jeremyfiel
force-pushed
the
feat/schema-test-coverage
branch
2 times, most recently
from
7046008 to
53c8b4f
Compare
|
opps. somehow the validate-markdown.yaml was deleted again. added it back. it will be replaced and updated by #291 pr after that one is merged. |
frankkilcommins
left a comment
frankkilcommins
left a comment
There was a problem hiding this comment.
Thanks @jeremyfiel - i'm requested changed on the examples to ensure they are valid (which is being fixed for the examples directly in #260 )
Can you also take a look at the merge conflicts?
jeremyfiel
force-pushed
the
feat/schema-test-coverage
branch
from
53c8b4f to
8c0204f
Compare
|
tbh, i'm not sure why this is a conflict. the file currently exists on |
* remove json version of schema * add package-lock.json * update test case examples to use proper ABNF syntax reused from OAS/Overlay projects
jeremyfiel
force-pushed
the
feat/schema-test-coverage
branch
from
8c0204f to
61685fe
Compare
|
interesting. adding the file back removes the conflict. I can create a separate pr to remove the file after this is merged.. lmk if that works |
|
taking inspiration from @ralfhandl to update the schema test coverage threshold to 100% like this will not work for this repo because we are not testing the JSON Schema 2020-12 keywords used in |
3 participants
This PR adds schema test coverage for the JSON Schema,
this is based on the work in the OAS and Overlay projects by @MikeRalphson and @ralfhandl
The schema tests do not cover JSON Schema 2020-12 keywords as defined by the
inputskeyword. All Arazzo specific keywords are covered by the tests.I've also included markdownlint-cli to clean up the spec file.