Replace commas with dashes to avoid naming errors#451
Open
Stichoza wants to merge 1 commit intoNext-Flip:devfrom
Open
Replace commas with dashes to avoid naming errors#451Stichoza wants to merge 1 commit intoNext-Flip:devfrom
Stichoza wants to merge 1 commit intoNext-Flip:devfrom
Conversation
According to lab.flipper.net, files are not allowed to contain commas. It displays an error right when you click rename on files. To avoid this error, it would be good to replace comma with dashes.
Member
|
What a goofy limitation, can't think of any reason why commas would be an issue, maybe they just forgot to add it |
Author
|
Yeah, but dashes are more common in datetime strings than commas anyways so idk |
Member
|
They are for dates, I would've used colons but that's an illegal character. Didn't use dots as they are for the extension. Commas are thin so the text doesn't go off screen too much and also it differentiates from the date and extension |
Contributor
I think mobile app had same limitation at ios, not sure if its still in place |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to lab.flipper.net, files are not allowed to contain commas. It displays an error right when you click rename on files. To avoid this error, it would be good to replace comma with dashes.
Example
What's new
For the reviewer