Skip to content

MATLAB version matrix#685

Merged
bendichter merged 62 commits intomainfrom
matlab-version-matrix
Mar 31, 2025
Merged

MATLAB version matrix#685
bendichter merged 62 commits intomainfrom
matlab-version-matrix

Conversation

@bendichter
Copy link
Copy Markdown
Contributor

@bendichter bendichter commented Mar 17, 2025

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@bendichter
Copy link
Copy Markdown
Contributor Author

It looks like we should skip Python tests for versions < 9.13. It's totally fine with me to skip specific tests that aren't supported in earlier versions are long as the core functionality is still being tested.

@ehennestad
Copy link
Copy Markdown
Collaborator

ehennestad commented Mar 19, 2025

It might work if testing with older versions of python as well. I.e MATLAB R2021a is compatible with python versions up to 3.8
See here: https://se.mathworks.com/support/requirements/python-compatibility.html

But I agree with your point and In general it would be nice to split the test suite into modules where one module would only test core functionality and the matrix testing could run that, and another module would run tutorials tests etc.

@ehennestad
Copy link
Copy Markdown
Collaborator

@ehennestad ehennestad self-requested a review March 31, 2025 19:34
Copy link
Copy Markdown
Collaborator

@ehennestad ehennestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are passing on all versions. This PR has also been tested on a Windows machine with MATLAB R2019b, and all tests passed

@bendichter bendichter merged commit 7d4e43e into main Mar 31, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants