replace inline checks with decorator#94
Open
samridhsharma wants to merge 25 commits intoNetflix:masterfrom
samridhsharma:develop
Open
replace inline checks with decorator#94samridhsharma wants to merge 25 commits intoNetflix:masterfrom samridhsharma:develop
samridhsharma wants to merge 25 commits intoNetflix:masterfrom
samridhsharma:develop
Conversation
Implemented #57. This allows batch outside collaborator repo adding.
- This will change how DUO environment variables are sent in. Please see the updated README. - This also adds support for hidden commands where help text is not specified. This is useful for commands that you have retired. This is so if users type in the retired command, they still get some output that you can control -- indicating to them that the command is retired and that another command should be used instead -- while not showing up in the help text.
Added multiple-domain DUO support
Fixed bug #81.
Added more threads to duo error messages
Small change to include a non-zero exit status if the docker build command failed for any reason.
Update for proper exit status
Addresses #83
Properly removes all macOS "Smart Quotes".
Contributor
|
Wow! Lots of good stuff in there. I will need a days to look it over. |
mikegrima
suggested changes
Oct 7, 2018
Contributor
mikegrima
left a comment
mikegrima
left a comment
There was a problem hiding this comment.
Awesome PR!
Please address the few items and I'll merge it in and make a new release.
| raise NoSecretsProvidedError("Must provide secrets to enable authentication.") | ||
| for variable, secret in secrets.items(): | ||
| if "DUO_" in variable: | ||
| domain, host, ikey, skey = secret.split(",") |
Contributor
There was a problem hiding this comment.
This seems incorrect. All 3 of the variables must be provided for DUO to work.
I would suggest keeping the old code here.
| "user_data_required": True, | ||
| "help": "Sets team permissions to a specific repository in a specific GitHub organization.", | ||
| "permitted_permissions": ["push", "pull"], # To grant admin, add this to the config for | ||
| "enabled": True # this command in the config.py. |
Contributor
There was a problem hiding this comment.
Please make disabled by default.
| "DUO-HOST": "xxxxxxxx.duosecurity.com", | ||
| "DUO-IKEY": "The IKEY for Duo", | ||
| "DUO-SKEY": "The SKEY for Duo" | ||
| "DUO_YOUR_DOMAIN": "your-domain-here.com,xxxxxxxx.duosecurity.com,THEDUOIKEY,THEDUOSKEY" |
Contributor
There was a problem hiding this comment.
I think I would prefer to keep this as is -- it won't break users who upgrade.
Unless you can convince me that this way is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.