Draft
Conversation
aalmada
force-pushed
the
GeneratorRefactor
branch
2 times, most recently
from
b1c0949 to
639aa73
Compare
aalmada
force-pushed
the
GeneratorRefactor
branch
from
430e623 to
ed34b10
Compare
aalmada
force-pushed
the
GeneratorRefactor
branch
2 times, most recently
from
35ed2b1 to
721fcb2
Compare
aalmada
force-pushed
the
GeneratorRefactor
branch
from
8a0a2f6 to
9d63e9f
Compare
aalmada
force-pushed
the
GeneratorRefactor
branch
from
1174194 to
013b6e6
Compare
aalmada
force-pushed
the
GeneratorRefactor
branch
from
ba8dd9a to
dc1c008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler is not able to infer the generics types when using constraints. For this reason, a source generator was used to generate all the generics mappings so that a developer doesn't have to explicitly specify the types when calling each operation. The source generator was an internal project, executed before packaging the library.
This refactoring changes the source generator to be publicly distributed and executed when compiling the projects that depend on Hyperlinq. It will only generate the overloads required by the project.
This refactoring is necessary because it's very hard to map the generics types in the way it was done. When executing on the project, the explicit types have already been declared. This makes the source generator much simpler, allows the generation of a lot less code. It can also perform more optimizations.