Skip to content

Feat hardware comp test#17

Merged
NestorDP merged 9 commits intomainfrom
feat-hardware-comp-test
Jan 21, 2026
Merged

Feat hardware comp test#17
NestorDP merged 9 commits intomainfrom
feat-hardware-comp-test

Conversation

@NestorDP
Copy link
Copy Markdown
Owner

Pull Request

Description

Related Issue(s)

  • Fixes #issue_number

Checklist

  • I have tested this code thoroughly.
  • My code follows the project's coding standards.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements hardware component functionality for the Littlebot robot, including control character validation in the driver, RT buffer interface updates, and hardware component configuration logic. However, the implementation contains critical bugs that prevent it from compiling or functioning correctly.

Changes:

  • Added control character validation to the driver's requestStatus() method with corresponding error handling
  • Implemented on_configure(), read(), and write() methods in the hardware component
  • Updated RT buffer interfaces and corrected namespace/include paths
  • Downgraded package format from 3 to 2 across multiple packages

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
littlebot_navigation/package.xml Downgraded package format to 2, but XML schema reference still points to format 3
littlebot_description/package.xml Downgraded package format to 2, but XML schema reference still points to format 3
littlebot_bringup/package.xml Downgraded package format to 2, but XML schema reference still points to format 3
littlebot/package.xml Downgraded package format to 2
littlebot_base/test/test_littlebot_driver.cpp Added control character validation tests and updated existing tests
littlebot_base/test/mock_rt_buffer.hpp Removed const qualifier from readRT() mock to match interface
littlebot_base/src/littlebot_hardware_component.cpp Implemented on_configure() with serial port, RT buffers, and timer setup; implemented read/write methods; contains critical bugs
littlebot_base/src/littlebot_driver.cpp Added control character validation and stripping logic in requestStatus()
littlebot_base/include/littlebot_base/types.hpp Added InvalidControlChar error type and counter
littlebot_base/include/littlebot_base/ros_rt_buffer.hpp Fixed namespace and include path; removed const from readRT()
littlebot_base/include/littlebot_base/littlebot_hardware_component.hpp Added RT buffer and timer member variables
littlebot_base/include/littlebot_base/i_rt_buffer.hpp Removed const qualifier from readRT() interface method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NestorDP NestorDP merged commit 69f12dc into main Jan 21, 2026
0 of 2 checks passed
@NestorDP NestorDP deleted the feat-hardware-comp-test branch January 21, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants