Open
Conversation
I will explain each change more in the commit commits
Myurius
reviewed
Feb 8, 2026
Contributor
Myurius
left a comment
Myurius
left a comment
There was a problem hiding this comment.
Pretty quick non thorough review
|
|
||
| ReloadScript(ahkpath) | ||
| { | ||
| static cmd := DllCall("GetCommandLine", "Str"), params := DllCall("shlwapi\PathGetArgs","Str",cmd,"Str") |
Contributor
There was a problem hiding this comment.
Not really any need for these to be static considering that this function only runs once
| global | ||
| if (ManualHotbarButton1 && ManualHotbarButton2 && ManualHotbarButton3 && ManualHotbarButton4 && ManualHotbarButton5 && ManualHotbarButton6 && ManualHotbarButton7) or (!ManualHotbarArmed1 && !ManualHotbarArmed2 && !ManualHotbarArmed3 && !ManualHotbarArmed4 && !ManualHotbarArmed5 && !ManualHotbarArmed6 && !ManualHotbarArmed7) | ||
| return | ||
| ManualHotbar["UnlockButton"].Visible :=0 |
Contributor
There was a problem hiding this comment.
Up to you, but personally i would change all boolean 1/0s to true/false just to show the intent a bit better
|
|
||
| nm_UnlockHotbar(*){ | ||
| global | ||
| if (ManualHotbarButton1 && ManualHotbarButton2 && ManualHotbarButton3 && ManualHotbarButton4 && ManualHotbarButton5 && ManualHotbarButton6 && ManualHotbarButton7) or (!ManualHotbarArmed1 && !ManualHotbarArmed2 && !ManualHotbarArmed3 && !ManualHotbarArmed4 && !ManualHotbarArmed5 && !ManualHotbarArmed6 && !ManualHotbarArmed7) |
Contributor
There was a problem hiding this comment.
This line is really long, maybe shorten it down by comparing 2 variables instead
| nm_saveManualHotbarGui(*){ | ||
| wp := Buffer(44) | ||
| DllCall("GetWindowPlacement", "UInt", ManualHotbar.Hwnd, "Ptr", wp) | ||
| x := NumGet(wp, 28, "Int"), y := NumGet(wp, 32, "Int") |
Contributor
There was a problem hiding this comment.
Pretty sure we can do all this by using built in functions instead
Myurius
reviewed
Feb 17, 2026
|
|
||
| nm_ToggleManualHotbar(GuiCtrl, param?,*){ | ||
| global | ||
| num := SubStr(GuiCtrl.Name, -1) |
Contributor
There was a problem hiding this comment.
I would rename this to something more descriptive rather than num if it's intended to be a global
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.