-
Notifications
You must be signed in to change notification settings - Fork 48
Add Hydrogen #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add Hydrogen #499
Conversation
…ted_elec_emissions_in_total)
| @@ -0,0 +1,159 @@ | |||
| # ********************************************************************************* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update any file with this header language to the more updated one-liner header for the license.
| installed_cost_per_kw::Real | ||
| om_cost_per_kw::Real | ||
| om_cost_per_kwh::Real | ||
| efficiency_kwh_per_kg::Real |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the most common way efficiency is characterized in fuel cells? I would think it would still be a fraction/% in terms of electric output per HHV of fuel (H2) input. Can this fuel cell not be fueled by other fuels? If this is only for H2, and kWh/kg is industry standard, then I'm fine to leave it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the most common way efficiency is characterized in fuel cells? I would think it would still be a fraction/% in terms of electric output per HHV of fuel (H2) input. Can this fuel cell not be fueled by other fuels? If this is only for H2, and kWh/kg is industry standard, then I'm fine to leave it as is.
@indu-manogaran or @lixiangk1 do you have an answer to this? I can update as needed in the active PR that we have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete this file!
No description provided.