Skip to content

GHP MVP #394

Open
ppinchuk wants to merge 45 commits intomainfrom
pp/ghp_start
Open

GHP MVP #394
ppinchuk wants to merge 45 commits intomainfrom
pp/ghp_start

Conversation

@ppinchuk
Copy link
Collaborator

MVP of geothermal heat pump ordinance extraction

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.57%. Comparing base (7e17785) to head (dc4d87a).

Files with missing lines Patch % Lines
compass/plugin/one_shot/components.py 14.28% 12 Missing ⚠️
compass/plugin/ordinance.py 20.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   54.49%   55.57%   +1.07%     
==========================================
  Files          61       61              
  Lines        5652     5679      +27     
  Branches      530      531       +1     
==========================================
+ Hits         3080     3156      +76     
+ Misses       2526     2475      -51     
- Partials       46       48       +2     
Flag Coverage Δ
unittests 55.57% <50.00%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an MVP geothermal heat pump (GHP) ordinance extractor using the schema-based “one-shot” plugin path, and updates LLM defaults/docs plus dependency pinning for Playwright consistency.

Changes:

  • Introduce a new ghp extraction plugin driven by a JSON5 schema + YAML config.
  • Update model/task routing helpers and add richer prompt/logging context for schema-based extraction.
  • Bump/pin key dependencies (notably nlr-elm, playwright, rebrowser-playwright) and align documentation with the new default model.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Bumps nlr-elm and pins Playwright + rebrowser-playwright versions in Pixi deps.
pixi.lock Updates resolved environments for the new dependency pins (Playwright, Node, etc.).
examples/execution_basics/README.rst Updates documented default model and override example.
docs/source/dev/plugin_development.rst Simplifies CLI invocation example to --config only.
docs/source/dev/advanced_plugin_development.rst Simplifies CLI invocation example to --config only.
compass/scripts/process.py Updates docstring default model to gpt-4o-mini (matches function default).
compass/plugin/ordinance.py Changes model-config selection logic to accept prioritized keys and adds new task fallbacks.
compass/plugin/one_shot/components.py Enhances schema-based prompts/logging and injects schema/date context into system prompt.
compass/plugin/one_shot/base.py Returns the generated plugin class after registration; adds docstring return section.
compass/extraction/wind/parse.py Adds TASK_ID to key parsers for task-specific model routing.
compass/extraction/solar/parse.py Adds TASK_ID to key parsers for task-specific model routing.
compass/extraction/small_wind/parse.py Adds TASK_ID to key parsers for task-specific model routing.
compass/extraction/ghp/plugin_config.yaml Adds GHP one-shot plugin configuration (schema path, prompts, keywords).
compass/extraction/ghp/geothermal_heat_pump_schema.json5 Adds the GHP extraction schema definition.
compass/extraction/ghp/__init__.py Registers the GHP extractor via the schema-based plugin factory.
compass/extraction/__init__.py Imports GHP plugin to register it.
compass/common/base.py Minor prompt wording tweak (“multiple applicable values”).
compass/__init__.py Exposes the new GHP extractor at package import time.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new computation Update that adds a new computation method p-high Priority: high topic-python-llm Issues/pull requests related to LLMs

Projects

None yet

3 participants