Skip to content

Ensure type-checker understands use of Submodules in llava_model#3257

Open
nschank wants to merge 3 commits intoNVIDIA:mainfrom
nschank:llava
Open

Ensure type-checker understands use of Submodules in llava_model#3257
nschank wants to merge 3 commits intoNVIDIA:mainfrom
nschank:llava

Conversation

@nschank
Copy link
Contributor

@nschank nschank commented Feb 4, 2026

What does this PR do ?

In order to safely refactor Submodules classes, I want to make sure I can easily find everywhere those classes are being referenced. This updates llava_model to appropriately type-check the submodules its introspecting into, which ensures the type-checker (and things like Find References in VSCode) will understand the usage of these objects below.

Relevant design doc: https://docs.google.com/document/d/1shyv0iKEzRdevLOlouF_NktbdJazvWifqxUwPXFigQE/edit?tab=t.0#heading=h.uwes2zo47yg6

Split out from #2834

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@nschank nschank requested review from a team as code owners February 4, 2026 20:31
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 4, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team February 4, 2026 20:32
@yashaswikarnati yashaswikarnati added the Final Review Apply this label to indicate that your PR is ready for final review. label Feb 4, 2026
@yashaswikarnati
Copy link
Contributor

/ok to test c23839a

@yashaswikarnati
Copy link
Contributor

/ok to test 8bcc0b8

@chtruong814
Copy link
Contributor

/ok to test 35920f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request Final Review Apply this label to indicate that your PR is ready for final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants