Skip to content

Cherry-pick optimizer override refactor from #2723#2835

Merged
FDecaYed merged 21 commits intoNVIDIA:devfrom
yaoyu-33:chore/optimizer-override-cherrypick
Jan 14, 2026
Merged

Cherry-pick optimizer override refactor from #2723#2835
FDecaYed merged 21 commits intoNVIDIA:devfrom
yaoyu-33:chore/optimizer-override-cherrypick

Conversation

@yaoyu-33
Copy link
Contributor

@yaoyu-33 yaoyu-33 commented Jan 6, 2026

Summary

Cherry-picks the changes from #2723 onto dev so that the flexible optimizer/scheduler override system is available there.

jstjohn added 16 commits January 6, 2026 14:14
… (no longer 1-1 constraint)

Signed-off-by: John St John <[email protected]>
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St John <[email protected]>
… for the user to make use of

Signed-off-by: John St John <[email protected]>
@yaoyu-33 yaoyu-33 requested review from a team as code owners January 6, 2026 22:16
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
Copy link
Contributor

ko3n1g commented Jan 6, 2026

/ok to test fb732d7

@yanring
Copy link
Contributor

yanring commented Jan 7, 2026

Hey @yaoyu-33, we have a customer asking for this feature. Any idea when the PR will be ready?

@yaoyu-33
Copy link
Contributor Author

yaoyu-33 commented Jan 7, 2026

/ok to test e2df2c7

@BoxiangW
Copy link
Contributor

/ok to test a0b78ce

Signed-off-by: Boxiang Wang <[email protected]>
@BoxiangW
Copy link
Contributor

/ok to test f796b9d

@yaoyu-33 yaoyu-33 enabled auto-merge January 13, 2026 19:23
@yaoyu-33 yaoyu-33 added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@FDecaYed FDecaYed added this pull request to the merge queue Jan 14, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 14, 2026
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St. John <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
Co-authored-by: John St John <[email protected]>
Co-authored-by: Boxiang Wang <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2026
@FDecaYed FDecaYed added this pull request to the merge queue Jan 14, 2026
Merged via the queue into NVIDIA:dev with commit b0a702b Jan 14, 2026
46 of 48 checks passed
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 21, 2026
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St. John <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
Co-authored-by: John St John <[email protected]>
Co-authored-by: Boxiang Wang <[email protected]>
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 21, 2026
Signed-off-by: John St John <[email protected]>
Signed-off-by: John St. John <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
Co-authored-by: John St John <[email protected]>
Co-authored-by: Boxiang Wang <[email protected]>
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants