Skip to content

[doc] chore: remove duplicate moe-comm-overlap skill#2943

Open
yaoyu-33 wants to merge 1 commit intomainfrom
yuya/remove-duplicate-moe-comm-overlap-skill
Open

[doc] chore: remove duplicate moe-comm-overlap skill#2943
yaoyu-33 wants to merge 1 commit intomainfrom
yuya/remove-duplicate-moe-comm-overlap-skill

Conversation

@yaoyu-33
Copy link
Contributor

@yaoyu-33 yaoyu-33 commented Mar 21, 2026

Summary

  • Removed the moe-comm-overlap skill (SKILL.md + card.yaml) which was fully subsumed by the more thorough expert-parallel-overlap skill
  • Cleaned up stale links in docs/skills-index.md (toctree entry) and docs/training/communication-overlap.md (related-docs links)

Test plan

  • Verify docs/skills-index.md toctree renders without broken references
  • Verify docs/training/communication-overlap.md related-docs links are all valid

Made with Cursor

Summary by CodeRabbit

  • Documentation
    • Removed comprehensive documentation for the MoE expert-parallel communication overlap optimization feature from the performance techniques section, including detailed information on configuration flags, prerequisites, system constraints, common pitfalls, and verification procedures.
    • Removed associated metadata and updated navigation references accordingly.

The moe-comm-overlap skill was fully subsumed by the more thorough
expert-parallel-overlap skill. Remove the duplicate and clean up
stale references in docs/skills-index.md and
docs/training/communication-overlap.md.

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Made-with: Cursor
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 21, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyu-33
Copy link
Contributor Author

/ok to test 0c26d75

@yaoyu-33 yaoyu-33 added the docs-only With great power comes great responsibility. label Mar 21, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 949bc659-2de2-413a-b67b-ff62d67d7ddc

📥 Commits

Reviewing files that changed from the base of the PR and between 3980ce4 and 0c26d75.

📒 Files selected for processing (4)
  • docs/skills-index.md
  • docs/training/communication-overlap.md
  • skills/perf-techniques/moe-comm-overlap/SKILL.md
  • skills/perf-techniques/moe-comm-overlap/card.yaml
💤 Files with no reviewable changes (4)
  • docs/skills-index.md
  • skills/perf-techniques/moe-comm-overlap/card.yaml
  • docs/training/communication-overlap.md
  • skills/perf-techniques/moe-comm-overlap/SKILL.md

📝 Walkthrough

Walkthrough

Removed MoE expert-parallel communication overlap skill documentation and metadata from the documentation structure, including deletion of the SKILL.md and card.yaml files and removal of all references from navigation indices and related documentation.

Changes

Cohort / File(s) Summary
Documentation Index & References
docs/skills-index.md, docs/training/communication-overlap.md
Removed toctree entry and documentation links referencing the MoE expert-parallel overlap skill from navigation and training documentation.
Skill Documentation & Metadata
skills/perf-techniques/moe-comm-overlap/SKILL.md, skills/perf-techniques/moe-comm-overlap/card.yaml
Deleted skill documentation file describing MoE expert-parallel communication overlap configuration and validation approach, and removed associated YAML card metadata containing skill summary, validation status, feature definitions, and constraints.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the duplicate moe-comm-overlap skill documentation and references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor documentation cleanup and removal of duplicate skill files with no code functionality changes, new features, or breaking changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yuya/remove-duplicate-moe-comm-overlap-skill

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-only With great power comes great responsibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant