fix: write distributed coverage to fixed path in minimax_m2 tests#2921
Open
ko3n1g wants to merge 1 commit intoyuya/add-minimax-m2-bridgefrom
Open
fix: write distributed coverage to fixed path in minimax_m2 tests#2921ko3n1g wants to merge 1 commit intoyuya/add-minimax-m2-bridgefrom
ko3n1g wants to merge 1 commit intoyuya/add-minimax-m2-bridgefrom
Conversation
The parallelism tests were writing coverage data to a pytest tmp_path, so the files were never visible to `coverage combine` at /opt/Megatron-Bridge/.coverage. Use the fixed container path (matching other model tests like deepseek), and remove the now-unnecessary in-process import workaround from the launch script. Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
added
the
needs-more-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_minimax_m2_conversion.pywere writing coverage data totmp_path / ".coverage"(a throwaway pytest temp dir), so the.coverage.*files were never visible tocoverage combineat/opt/Megatron-Bridge/.coveragecoverage xmlto fail with "No data to report" even though all 4 tests passed--data-file=/opt/Megatron-Bridge/.coverage, matching how other model tests (e.g. deepseek) are writtenL0_Launch_models_minimax_m2.shTest plan
L0_Launch_models_minimax_m2passes (all 4 tests pass + coverage collection succeeds)🤖 Generated with Claude Code