fix(tests): stabilize Linux native hashing and Bitcoin job tests#16
Open
fix(tests): stabilize Linux native hashing and Bitcoin job tests#16
Conversation
Bring the latest dev changes into this branch so the missing hasher fixes are rebased onto the workflow/native include fixes from PR #13 before re-running CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes the remaining failing test issues after the native Linux build/workflow changes.
Changes made
.solibraries frombuild/into the Miningcore output directoryLyra2Rev2_HashandLyra2Rev3_Hashexpected values to match the current native Linux implementationBitcoinJobTeststo assert the current valid behavior instead of stale assumptionsWhy
Tests were failing for two separate reasons:
libmultihash.sowere built but not ending up in the runtime/test output foldersValidation
dotnet test --no-build src --filter "FullyQualifiedName~BitcoinJobTests"✅