Skip to content

Fix native build issues and modernize GitHub Actions workflows#13

Merged
NINJAK1DD merged 3 commits intodevfrom
fix-actions-and-native-builds
Apr 19, 2026
Merged

Fix native build issues and modernize GitHub Actions workflows#13
NINJAK1DD merged 3 commits intodevfrom
fix-actions-and-native-builds

Conversation

@NINJAK1DD
Copy link
Copy Markdown
Owner

Summary

This PR fixes native build issues affecting CI and updates GitHub Actions workflow versions.

Changes included

  • fixed missing integer type headers in native code
  • adjusted native build handling for RandomARQ and Panthera-related build failures
  • updated GitHub Actions workflow actions to current supported versions
  • cleaned up CI so the workflow runs more reliably on GitHub-hosted runners

Why

The existing CI pipeline was failing during native library builds and some workflow actions were using older versions. This PR brings the build pipeline back into a working state and modernizes the workflow definitions.

Validation

  • branch pushed successfully
  • pull request created against dev
  • GitHub Actions checks to be used as validation for the updated workflow and native build fixes

Risk

Low to moderate. Changes affect native build and CI workflow behavior, so the main risk area is build/runtime compatibility.

Rollback

Revert this PR if CI or native builds regress after merge.

@NINJAK1DD
Copy link
Copy Markdown
Owner Author

This PR is intentionally limited to:

  • native include/build fixes
  • GitHub Actions modernization

The remaining failing checks are pre-existing and reproduce on dev itself.

I verified this locally with:

dotnet test src --filter "FullyQualifiedName~CoinTemplateValidationTest|FullyQualifiedName~BitcoinJobTests"

The same failures occur on dev:

  • CoinTemplateValidationTest due to coins.json referencing x11kvs while only x11 is registered
  • BitcoinJobTests failing with low difficulty share (...)

I will open a separate follow-up branch/PR for those repo-level test fixes so this PR stays focused.

@NINJAK1DD
Copy link
Copy Markdown
Owner Author

Merging this despite red CI because the current failures are expected and unrelated to this PR’s scope:

@NINJAK1DD NINJAK1DD merged commit 1a061ad into dev Apr 19, 2026
1 check failed
NINJAK1DD added a commit that referenced this pull request Apr 19, 2026
Bring the latest dev changes into this branch so the missing hasher fixes are
rebased onto the workflow/native include fixes from PR #13 before re-running CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant