Skip to content

feat: add CoreNetwork API coverage#372

Open
jmcte wants to merge 2 commits intoN4S4:masterfrom
OMT-Global:pr/core-network
Open

feat: add CoreNetwork API coverage#372
jmcte wants to merge 2 commits intoN4S4:masterfrom
OMT-Global:pr/core-network

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented Apr 17, 2026

Summary

  • add CoreNetwork wrapper coverage for DSM network APIs
  • include authentication, IPv6, MAC clone, OVS, PPPoE relay, static routes, traffic control, UPnP, and WOL helpers
  • add focused unit tests for request construction

Tests

  • python -m pytest tests/test_core_network.py

@jmcte jmcte force-pushed the pr/core-network branch from 461d12f to da9b9e9 Compare April 17, 2026 12:46
@jmcte jmcte force-pushed the pr/core-network branch from 0a688d5 to 00bef8f Compare April 18, 2026 21:32
@jmcte
Copy link
Copy Markdown
Contributor Author

jmcte commented Apr 18, 2026

I proactively updated the tests here to match the same request-contract approach from the CoreExternalDevice PR. These now assert API namespace, path, version, DSM method, request parameters, optional parameter omission, and boolean conversion for representative wrapper methods instead of only checking that request_data was called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant