Open
Conversation
2d3afc9 to
4d27893
Compare
Collaborator
|
Are all these unit tests useful at all? What do they actually test? Just that the request fires? If no actual logic is being tested, then I don't see the purpose for there even being tests. |
Owner
|
I agree with @joeperpetua |
db2210d to
bd8bd1f
Compare
Contributor
Author
|
Thanks, that was fair feedback. I updated the tests so they now assert request contracts instead of only checking that request_data was called. They validate the API namespace, path, version, DSM method, request parameters, optional parameter omission, and boolean conversion for representative wrapper methods. I made the same adjustment on the CoreNetwork PR because it had the same test pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests