Extracted countdownController, disable autostart and added duration to reset method and some more#64
Open
trashcoder wants to merge 6 commits intoMuhammadUsamaSiddiqui:masterfrom
Open
Extracted countdownController, disable autostart and added duration to reset method and some more#64trashcoder wants to merge 6 commits intoMuhammadUsamaSiddiqui:masterfrom
trashcoder wants to merge 6 commits intoMuhammadUsamaSiddiqui:masterfrom
Conversation
trashcoder
commented
Feb 28, 2024
trashcoder
commented
- extracted countdownController to a separate file.
- moved some attributes from circular_countdown_timer class to countdown_controller class where it belongs better
- added duration to reset method
- removed autostart from reset method
- extracted getTimeFormatted and defaultFormat to a separate file
- switched to ValueNotifier like in original repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.