Skip to content

HTML5 fixes #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoritzBrueckner merged 3 commits into from
Jul 7, 2026
+17 −15
Merged

HTML5 fixes #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0d0e57
Fix no sound in debug mode and some releases for HTML5 builds
moisesjpelaez Apr 13, 2026
68c19f1
Prevent crash when replaying the same audio in mobile HTML5 & refactor
moisesjpelaez May 27, 2026
2e53da9
Prevent mobile audio cleanup crash
moisesjpelaez May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/aura/Aura.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class Aura {
audioContext = kha.js.MobileWebAudio._context;
}
else {
audioContext = new js.html.audio.AudioContext();
audioContext = kha.audio2.Audio._context;
}
#end

Expand Down
30 changes: 16 additions & 14 deletions Sources/aura/channels/Html5StreamChannel.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ class Html5StreamChannel extends BaseChannel {
See https://github.com/Kode/Kha/issues/299 and
https://github.com/Kode/Kha/commit/12494b1112b64e4286b6a2fafc0f08462c1e7971
**/
@:access(kha.js.MobileWebAudioChannel)
class Html5MobileStreamChannel extends BaseChannel {
var audioContext: AudioContext;
var khaChannel: kha.js.MobileWebAudioChannel;
Expand Down Expand Up @@ -289,7 +290,7 @@ class Html5MobileStreamChannel extends BaseChannel {
leftGain.connect(merger, 0, 0);
rightGain.connect(merger, 0, 1);
merger.connect(attenuationGain);
attenuationGain.connect(@:privateAccess khaChannel.gain);
attenuationGain.connect(khaChannel.gain);

reconnectKhaChannelNodes();
}
Expand All @@ -299,7 +300,8 @@ class Html5MobileStreamChannel extends BaseChannel {
khaChannel.position = 0;
}

@:privateAccess khaChannel.source.onended = null;
khaChannel.source.onended = null;
khaChannel.stopped = true;
khaChannel.play();
// `MobileWebAudioChannel` recreates a 'source' when `khaChannel.play()` is called
// Reconnect 'source' and 'gain' to the proper nodes
Expand All @@ -323,18 +325,18 @@ class Html5MobileStreamChannel extends BaseChannel {
Clean up Web Audio nodes. Called automatically when `BaseChannelHandle.setMixChannel(null)` is used.
**/
override function cleanUp() {
@:privateAccess khaChannel.source.onended = null;
@:privateAccess khaChannel.source.disconnect();
khaChannel.source.onended = null;
khaChannel.source.disconnect();
splitter.disconnect();
leftGain.disconnect();
rightGain.disconnect();
merger.disconnect();
attenuationGain.disconnect();
@:privateAccess khaChannel.gain.disconnect();
khaChannel.stop();
khaChannel.gain.disconnect();
if (!finished && !paused) khaChannel.stop();

@:privateAccess khaChannel.gain = null;
@:privateAccess khaChannel.source = null;
khaChannel.gain = null;
khaChannel.source = null;
splitter = null;
leftGain = null;
rightGain = null;
Expand Down Expand Up @@ -367,17 +369,17 @@ class Html5MobileStreamChannel extends BaseChannel {

function updatePlaybackRate() {
try {
@:privateAccess khaChannel.source.playbackRate.value = pitch * dopplerRatio;
khaChannel.source.playbackRate.value = pitch * dopplerRatio;
}
catch (e) {}
}

function reconnectKhaChannelNodes() {
@:privateAccess khaChannel.gain.disconnect();
@:privateAccess khaChannel.source.disconnect();
@:privateAccess khaChannel.source.connect(splitter);
@:privateAccess khaChannel.source.onended = stop;
@:privateAccess khaChannel.gain.connect(parentChannel.gain);
khaChannel.gain.disconnect();
khaChannel.source.disconnect();
khaChannel.source.connect(splitter);
khaChannel.source.onended = stop;
khaChannel.gain.connect(parentChannel.gain);
}
}

Expand Down